Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: media/base/channel_mixer_unittest.cc

Issue 672793002: Expose the internal MatrixBuilder class as ChannelMixingMatrix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add new files to BUILD.gn Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/channel_mixer_unittest.cc
diff --git a/media/base/channel_mixer_unittest.cc b/media/base/channel_mixer_unittest.cc
index ac228e661dd39bb5869b4e98ddafa624807cdc4a..e07d95110ee362385f10da13be7ae2823eb234a0 100644
--- a/media/base/channel_mixer_unittest.cc
+++ b/media/base/channel_mixer_unittest.cc
@@ -24,6 +24,7 @@ TEST(ChannelMixerTest, ConstructAllPossibleLayouts) {
input_layout <= CHANNEL_LAYOUT_MAX;
input_layout = static_cast<ChannelLayout>(input_layout + 1)) {
for (ChannelLayout output_layout = CHANNEL_LAYOUT_MONO;
+ // TODO(wtc): why do we only test up to CHANNEL_LAYOUT_STEREO_DOWNMIX?
DaleCurtis 2014/10/23 16:49:05 Hmm, I don't remember, may be a bug. What happens
wtc 2014/10/23 18:39:45 If I change it to MAX, this CHECK will fail: //
DaleCurtis 2014/10/23 19:23:50 Haha, whoops. Thanks for fixing :)
output_layout < CHANNEL_LAYOUT_STEREO_DOWNMIX;
output_layout = static_cast<ChannelLayout>(output_layout + 1)) {
// DISCRETE can't be tested here based on the current approach.

Powered by Google App Engine
This is Rietveld 408576698