Http cache: Fix DCHECK with POSTs and a disabled cache.

net/http/http_cache_transaction.cc

Index: net/http/http_cache_transaction.cc
diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc
index 5441e90f33ffa7d27377bb07dac4a67ab954338c..fa6397db65e1372acc0dc0255c827535c5a8e8e2 100644
--- a/net/http/http_cache_transaction.cc
+++ b/net/http/http_cache_transaction.cc
@@ -1219,7 +1219,8 @@ int HttpCache::Transaction::DoSuccessfulSendRequest() {
     mode_ = NONE;
   }
 
-  if (request_->method == "POST" &&
+  if (!(effective_load_flags_ & LOAD_DISABLE_CACHE) &&

[davidben, 2014/10/23 19:14:43]

Should this be mode_ != NONE or mode_ & WRITE or something of the sort? It looks
like LOAD_DISABLE_CACHE figures into ShouldPassThrough() which then controls
mode_.

[rvargas (doing something else), 2014/10/23 19:36:09]

There are multiple causes for mode_ to change between ShouldPassThrough() and
this point. What this line is saying is "unless the conditions when request was
made indicated that this should not affect the cache at all, we should
invalidate any cached entry at this point"

[davidben, 2014/10/23 19:45:42]

Ohh, I see. This is about invalidating GETs after a successful POST, not
something about a cache entry attached to the current request or so.

Perhaps it's worth a comment above 1222 so it's clearer what this block is
doing?

[rvargas (doing something else), 2014/10/23 20:06:15]

Done.

+      request_->method == "POST" &&
       NonErrorResponse(new_response->headers->response_code())) {
     cache_->DoomMainEntryForUrl(request_->url);
   }