Issue 67273004: Fix invalid reuse of weak global handle in GetScriptWrapper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 67273004: Fix invalid reuse of weak global handle in GetScriptWrapper. (Closed)

Created:
7 years, 1 month ago by Michael Starzinger

Modified:
7 years, 1 month ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix invalid reuse of weak global handle in GetScriptWrapper. This fixes a direct usage of a weak global handle in GetScriptWrapper that just casted it to a strong local handle, while a subsequent GC might clear it. Handlepocalypse anyone? R=machenbach@chromium.org BUG=v8:2988 TEST=mjsunit/regress/regress-2988 Committed: http://code.google.com/p/v8/source/detail?r=17622

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -21 lines)			Patch
	M	src/handles.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-2988.js	View		1 chunk	+8 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r17622.

Expand Messages | Collapse Messages