Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 672723002: Extend SkFontMgr_Custom to cover ttc, otf, pfb. (Closed)

Created:
6 years, 2 months ago by bungeman-skia
Modified:
6 years, 1 month ago
Reviewers:
hal.canary, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Extend SkFontMgr_Custom to cover ttc, otf, pfb. Adds ability to test ScanFont with Type1 (pfb) fonts and fonts with multiple faces (ttc). Committed: https://skia.googlesource.com/skia/+/ee0c2e4fd429424beaa35f29e7f656997ba3f115 Committed: https://skia.googlesource.com/skia/+/14df8339841f246a7337a8fb0d90f1b7ee689619

Patch Set 1 #

Patch Set 2 : Stop creating and destorying FT_Library all the time. #

Patch Set 3 : Keep FT_Stream alive, protect library with mutex. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -65 lines) Patch
M src/fonts/SkFontMgr_fontconfig.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 2 4 chunks +57 lines, -18 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.h View 1 2 2 chunks +13 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_linux.cpp View 1 5 chunks +43 lines, -37 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 1 5 chunks +9 lines, -5 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
bungeman-skia
The biggest change here is to SkFontHost_linux.cpp which halcanary is most interested in. The motivation ...
6 years, 1 month ago (2014-10-28 16:41:36 UTC) #2
reed1
lgtm
6 years, 1 month ago (2014-10-28 16:49:32 UTC) #3
hal.canary
On 2014/10/28 16:41:36, bungeman1 wrote: > The biggest change here is to SkFontHost_linux.cpp which halcanary ...
6 years, 1 month ago (2014-10-28 16:50:15 UTC) #4
bungeman-skia
On 2014/10/28 16:50:15, Hal Canary wrote: > On 2014/10/28 16:41:36, bungeman1 wrote: > > The ...
6 years, 1 month ago (2014-10-28 17:30:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672723002/20001
6 years, 1 month ago (2014-10-28 17:33:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ee0c2e4fd429424beaa35f29e7f656997ba3f115
6 years, 1 month ago (2014-10-28 17:46:11 UTC) #8
bungeman-skia
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/685803003/ by bungeman@google.com. ...
6 years, 1 month ago (2014-10-28 19:03:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672723002/40001
6 years, 1 month ago (2014-10-28 21:58:16 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 22:07:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 14df8339841f246a7337a8fb0d90f1b7ee689619

Powered by Google App Engine
This is Rietveld 408576698