Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 672673005: Remove IsHighDPIEnabled, move EnableHighDPISupport to only place it's used (Closed)

Created:
6 years, 2 months ago by scottmg
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, ananta
Base URL:
https://chromium.googlesource.com/chromium/src.git@dpi-cleanup-5
Project:
chromium
Visibility:
Public.

Description

Remove IsHighDPIEnabled, move EnableHighDPISupport to only place it's used R=sky@chromium.org BUG=143619 Committed: https://crrev.com/2525dae3107f78a01bf0f7f623db630c93375c34 Cr-Commit-Position: refs/heads/master@{#300986}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : review #

Patch Set 6 : rebase-6 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -152 lines) Patch
M ash/display/display_info.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M chrome/app/chrome_exe_main_win.cc View 1 2 3 3 chunks +55 lines, -1 line 0 comments Download
M ui/base/layout.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 2 3 4 5 2 chunks +7 lines, -12 lines 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle_win.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/test/run_all_unittests.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/screen_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/win/dpi.h View 1 2 3 4 5 2 chunks +0 lines, -16 lines 0 comments Download
M ui/gfx/win/dpi.cc View 1 2 3 4 5 5 chunks +8 lines, -113 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
scottmg
6 years, 2 months ago (2014-10-23 04:21:05 UTC) #1
sky
LGTM https://codereview.chromium.org/672673005/diff/60001/ui/gfx/screen_win.cc File ui/gfx/screen_win.cc (right): https://codereview.chromium.org/672673005/diff/60001/ui/gfx/screen_win.cc#newcode163 ui/gfx/screen_win.cc:163: if (!(GetDPIScale() > 1.0)) { nit: GetDPIScale == ...
6 years, 2 months ago (2014-10-23 16:53:51 UTC) #2
scottmg
https://codereview.chromium.org/672673005/diff/60001/ui/gfx/screen_win.cc File ui/gfx/screen_win.cc (right): https://codereview.chromium.org/672673005/diff/60001/ui/gfx/screen_win.cc#newcode163 ui/gfx/screen_win.cc:163: if (!(GetDPIScale() > 1.0)) { On 2014/10/23 16:53:51, sky ...
6 years, 2 months ago (2014-10-23 22:09:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672673005/100001
6 years, 2 months ago (2014-10-23 22:13:00 UTC) #5
commit-bot: I haz the power
Committed patchset #6 (id:100001)
6 years, 2 months ago (2014-10-23 23:43:19 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 23:43:59 UTC) #7
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/2525dae3107f78a01bf0f7f623db630c93375c34
Cr-Commit-Position: refs/heads/master@{#300986}

Powered by Google App Engine
This is Rietveld 408576698