Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 672663002: cc: Correct expansion of invalidation for tiles outside of interest rect (Closed)

Created:
6 years, 2 months ago by danakj
Modified:
6 years, 2 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2171
Project:
chromium
Visibility:
Public.

Description

cc: Correct expansion of invalidation for tiles outside of interest rect Previously we subtracted the interest_rect_over_tiles from the invalid_rect when looking to see what invalidation would not be recorded but this computation is wrong. Instead, we need to expand the invalidation to the bounds of the tiles it touches (including tiles it touches on borders). Then we can subtract the interest rect expanded to the bounds of tiles it touches (including tiles it touches on borders). This makes each expansion match the iteration of the given rect where we include borders. If a tile is touched only on the border by invalidation, but the tile is not touched even on a border by the interest rect, we want to expand the invalidation to cover that tile. TBR=enne, vmpstr BUG=421729 Review URL: https://codereview.chromium.org/657913002 Cr-Commit-Position: refs/heads/master@{#299750} (cherry picked from commit 04a24ab064c9e19d17d481b7649387a2ed2402ff) Committed: https://chromium.googlesource.com/chromium/src/+/a28c3078ec897a97924dfb8bb853111a8743fe63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -13 lines) Patch
M cc/resources/picture_pile.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/resources/picture_pile.cc View 3 chunks +19 lines, -13 lines 0 comments Download
M cc/resources/picture_pile_unittest.cc View 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
danakj
6 years, 2 months ago (2014-10-22 17:00:27 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a28c3078ec897a97924dfb8bb853111a8743fe63 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698