Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 672653002: Test that AutoEnrollmentClient stores server-backed state correctly (Closed)

Created:
6 years, 2 months ago by bartfab (slow)
Modified:
6 years, 2 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@e_1_425574_add_disabled_device_screen
Project:
chromium
Visibility:
Public.

Description

Test that AutoEnrollmentClient stores server-backed state correctly This CL extends the AutoEnrollmentClient unit tests to verify that the server-backed state is persisted correctly persisted in local state. BUG=425574 TEST=Extended unit tests Committed: https://crrev.com/e9c23c4d69013266ef5ee78a86a401784a062a41 Cr-Commit-Position: refs/heads/master@{#300860}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc View 1 26 chunks +61 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bartfab (slow)
Hi Joao, Could you take a look please?
6 years, 2 months ago (2014-10-22 16:34:15 UTC) #2
Joao da Silva
Nice, lgtm https://codereview.chromium.org/672653002/diff/1/chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc File chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc (right): https://codereview.chromium.org/672653002/diff/1/chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc#newcode510 chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc:510: EXPECT_TRUE(HasCachedDecision()); Isn't this redundant given the VerifyServerBackedState ...
6 years, 2 months ago (2014-10-22 18:22:38 UTC) #3
bartfab (slow)
https://codereview.chromium.org/672653002/diff/1/chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc File chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc (right): https://codereview.chromium.org/672653002/diff/1/chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc#newcode510 chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc:510: EXPECT_TRUE(HasCachedDecision()); On 2014/10/22 18:22:38, Joao da Silva wrote: > ...
6 years, 2 months ago (2014-10-23 08:57:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672653002/20001
6 years, 2 months ago (2014-10-23 08:58:14 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-23 09:43:39 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 09:44:21 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9c23c4d69013266ef5ee78a86a401784a062a41
Cr-Commit-Position: refs/heads/master@{#300860}

Powered by Google App Engine
This is Rietveld 408576698