Issue 672623003: ARM64: Fix stack manipulation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 672623003: ARM64: Fix stack manipulation. (Closed)

Created:
6 years, 2 months ago by Rodolph Perfetta (ARM)

Modified:
6 years, 2 months ago

Reviewers:
ulan, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

ARM64: Fix stack manipulation. Builtins::Generate_StringConstructCode was claiming stack space instead of giving it back. BUG=chromium:425585 LOG=Y R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24815

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -15 lines)			Patch
	M	src/arm64/builtins-arm64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	A +	test/mjsunit/regress/regress-crbug-425585.js	View		1 chunk	+15 lines, -14 lines	0 comments	Download

Total messages: 5 (1 generated)

Jakob Kummerow

LGTM. Looks easy enough :-) Minor nit: in the future, you can use the 3-line ...

6 years, 2 months ago (2014-10-22 17:48:53 UTC) #3

Rodolph Perfetta (ARM)

6 years, 2 months ago (2014-10-22 18:24:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as 24815 (presubmit successful).