Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 672583003: remove ui/base/win/dpi_setup.cc (Closed)

Created:
6 years, 2 months ago by scottmg
Modified:
6 years, 2 months ago
Reviewers:
jam, sky
CC:
chromium-reviews, darin-cc_chromium.org, jam, oshima, ananta
Base URL:
https://chromium.googlesource.com/chromium/src.git@dpi-cleanup-2
Project:
chromium
Visibility:
Public.

Description

remove ui/base/win/dpi_setup.cc Unnecessary wrapper. TBR=jam@chromium.org R=sky@chromium.org BUG=143619 Committed: https://crrev.com/aaa54ca8dc57118f0f81cf51198adb879ca6bfcc Cr-Commit-Position: refs/heads/master@{#300923}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase-3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -50 lines) Patch
M content/app/content_main_runner.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/base/ui_base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/base/win/dpi_setup.h View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/base/win/dpi_setup.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
scottmg
6 years, 2 months ago (2014-10-23 03:38:53 UTC) #1
sky
LGTM https://codereview.chromium.org/672583003/diff/1/content/app/content_main_runner.cc File content/app/content_main_runner.cc (right): https://codereview.chromium.org/672583003/diff/1/content/app/content_main_runner.cc#newcode636 content/app/content_main_runner.cc:636: gfx::InitDeviceScaleFactor(gfx::GetDPIScale()); I hate the inconsistency here. InitDeviceScaleFactor takes ...
6 years, 2 months ago (2014-10-23 04:19:13 UTC) #2
scottmg
tbr jam for content/app/
6 years, 2 months ago (2014-10-23 17:18:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672583003/20001
6 years, 2 months ago (2014-10-23 17:19:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-23 18:57:46 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 18:58:23 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/aaa54ca8dc57118f0f81cf51198adb879ca6bfcc
Cr-Commit-Position: refs/heads/master@{#300923}

Powered by Google App Engine
This is Rietveld 408576698