Issue 672573002: DevTools: _base64ToSize doesn't check content param for null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 672573002: DevTools: _base64ToSize doesn't check content param for null. (Closed)

Created:
6 years, 2 months ago by loislo

Modified:
6 years, 2 months ago

Reviewers:
vsevik, pfeldman, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: _base64ToSize doesn't check content param for null. BUG=425514 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184170

Patch Set 1 #

Patch Set 2 : return type annotation #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	Source/devtools/front_end/source_frame/ImageView.js	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672573002/20001

6 years, 2 months ago (2014-10-22 09:39:57 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-10-22 11:19:03 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 184170

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages