Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 672543002: Use getauxval() if available. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
Paweł Hajdan Jr., v8-dev
Project:
v8
Visibility:
Public.

Description

Use getauxval() if available. This fixes the problem of not being able to detect ARM features on ChromeOS because sandbox cannot access /proc/self/auxv and /proc/cpuinfo there. Drive-by-cleanup to libc detection in two other places. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24789

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M include/v8config.h View 2 chunks +0 lines, -3 lines 1 comment Download
M src/base/cpu.cc View 4 chunks +14 lines, -6 lines 0 comments Download
M src/sampler.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-10-22 06:14:29 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/672543002/diff/1/include/v8config.h File include/v8config.h (left): https://codereview.chromium.org/672543002/diff/1/include/v8config.h#oldcode123 include/v8config.h:123: // V8_LIBC_UCLIBC - uClibc This was unused and crappy, ...
6 years, 2 months ago (2014-10-22 06:15:07 UTC) #3
Sven Panne
lgtm
6 years, 2 months ago (2014-10-22 06:40:38 UTC) #4
Benedikt Meurer
6 years, 2 months ago (2014-10-22 06:42:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24789 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698