Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 67253003: Reland: Move ExtensionProcessManager to src/extensions, part 4 (Closed)

Created:
7 years, 1 month ago by James Cook
Modified:
7 years, 1 month ago
Reviewers:
CC:
chromium-reviews, vandebo (ex-Chrome), sadrul, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, davemoore+watch_chromium.org, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vsevik, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, kalyank, paulirish+reviews_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, Lei Zhang, tfarina, yurys, tommycli, robertshield, pfeldman, Greg Billock, ben+ash_chromium.org, Yoyo Zhou, benwells
Visibility:
Public.

Description

Reland: Move ExtensionProcessManager to src/extensions, part 4 Reland of https://codereview.chromium.org/62713003/ - the original patch broke the Google Chrome OS official builder due to a missing dependency on the extensions api target in extensions/extensions.gyp. * Move c/b/extensions/extension_process_manager.h to extensions/browser/process_manager.h * Rename ExtensionsProcessManager to ProcessManager * Place it in the "extensions" namespace BUG=313481 TEST=browser_tests, unit_tests TBR=miket@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234149

Patch Set 1 #

Patch Set 2 : fix dependencies #

Patch Set 3 : rebase process_manager #

Patch Set 4 : rebase process_manager #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -1711 lines) Patch
M apps/launcher.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M apps/shell_window.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/apps/window_controls_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 6 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/automation/automation_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/alert_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/messaging/extension_message_port.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/system_storage/system_storage_eject_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/browsertest_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/chrome_notification_observer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/devtools_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/event_router.cc View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_bindings_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.h View 2 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 4 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_host_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/extensions/extension_process_manager.h View 1 chunk +0 lines, -221 lines 0 comments Download
D chrome/browser/extensions/extension_process_manager.cc View 1 2 1 chunk +0 lines, -853 lines 0 comments Download
D chrome/browser/extensions/extension_process_manager_browsertest.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D chrome/browser/extensions/extension_process_manager_unittest.cc View 1 chunk +0 lines, -136 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_system.h View 1 2 3 7 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 1 2 3 6 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_test_notification_observer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/gpu_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/gtalk_extension_browsertest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 12 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/extensions/notifications_apitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/process_management_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/extensions/process_manager_browsertest.cc View 4 chunks +9 lines, -10 lines 0 comments Download
A + chrome/browser/extensions/process_manager_unittest.cc View 6 chunks +22 lines, -15 lines 0 comments Download
M chrome/browser/extensions/process_map.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/suggest_permission_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.h View 1 2 3 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 1 2 3 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/memory_details.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/extension_process_resource_provider.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/common/common_injected.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/picasa/test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/DEPS View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M extensions/browser/info_map.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/lazy_background_task_queue.cc View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/lazy_background_task_queue_unittest.cc View 4 chunks +14 lines, -16 lines 0 comments Download
A + extensions/browser/process_manager.h View 10 chunks +24 lines, -24 lines 0 comments Download
A + extensions/browser/process_manager.cc View 1 2 41 chunks +101 lines, -118 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/67253003/80001
7 years, 1 month ago (2013-11-09 21:43:52 UTC) #1
commit-bot: I haz the power
7 years, 1 month ago (2013-11-10 00:34:15 UTC) #2
Message was sent while issue was closed. 
Change committed as 234149

Powered by Google App Engine
This is Rietveld 408576698