Issue 67252: Disabling the FFmpegDemuxerTest.ReadAndSeek test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 67252: Disabling the FFmpegDemuxerTest.ReadAndSeek test. (Closed)

Created:
11 years, 8 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Disabling the FFmpegDemuxerTest.ReadAndSeek test. There's a subtle threading bug that keeps popping up on the build bots. Will work on a fix. BUG=10653

Patch Set 3 : Switched DISABLED #

Patch Set 4 : Added crbug.com link #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	media/filters/ffmpeg_demuxer_unittest.cc	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

http://codereview.chromium.org/67252/diff/1/2 File media/filters/ffmpeg_demuxer_unittest.cc (right): http://codereview.chromium.org/67252/diff/1/2#newcode382 Line 382: TEST(DISABLED_FFmpegDemuxerTest, ReadAndSeek) { No, that's TEST(FFmpegDemuxerTest, DISABLED_ReadAndSeek) { ...

11 years, 8 months ago (2009-04-17 17:09:17 UTC) #1

M-A Ruel

That's not the test suite you disable, that's the test case. http://codereview.chromium.org/67252/diff/5/1002 File media/filters/ffmpeg_demuxer_unittest.cc (right): ...

11 years, 8 months ago (2009-04-17 17:24:00 UTC) #3

scherkus (not reviewing)

haha turns out it doesn't make a difference but I agree it's more clear if ...

11 years, 8 months ago (2009-04-17 17:28:55 UTC) #4

lgtm with the comment fixed.