Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 67252: Disabling the FFmpegDemuxerTest.ReadAndSeek test. (Closed)

Created:
11 years, 8 months ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Disabling the FFmpegDemuxerTest.ReadAndSeek test. There's a subtle threading bug that keeps popping up on the build bots. Will work on a fix. BUG=10653

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added bug #

Total comments: 2

Patch Set 3 : Switched DISABLED #

Patch Set 4 : Added crbug.com link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M media/filters/ffmpeg_demuxer_unittest.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
http://codereview.chromium.org/67252/diff/1/2 File media/filters/ffmpeg_demuxer_unittest.cc (right): http://codereview.chromium.org/67252/diff/1/2#newcode382 Line 382: TEST(DISABLED_FFmpegDemuxerTest, ReadAndSeek) { No, that's TEST(FFmpegDemuxerTest, DISABLED_ReadAndSeek) { ...
11 years, 8 months ago (2009-04-17 17:09:17 UTC) #1
scherkus (not reviewing)
added bugs
11 years, 8 months ago (2009-04-17 17:21:18 UTC) #2
M-A Ruel
That's not the test suite you disable, that's the test case. http://codereview.chromium.org/67252/diff/5/1002 File media/filters/ffmpeg_demuxer_unittest.cc (right): ...
11 years, 8 months ago (2009-04-17 17:24:00 UTC) #3
scherkus (not reviewing)
haha turns out it doesn't make a difference but I agree it's more clear if ...
11 years, 8 months ago (2009-04-17 17:28:55 UTC) #4
M-A Ruel
11 years, 8 months ago (2009-04-17 17:31:35 UTC) #5
lgtm with the comment fixed.

Powered by Google App Engine
This is Rietveld 408576698