Issue 67249: EscapeQueryParamValue differs from encodeURIComponent in that it doesn't esca...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 67249: EscapeQueryParamValue differs from encodeURIComponent in that it doesn't esca... (Closed)

Created:
11 years, 8 months ago by Glen Murphy

Modified:
9 years, 5 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

EscapeQueryParamValue differs from encodeURIComponent in that it doesn't escape spaces, so we have to do some manual fiddling to make searches that have come from the New Tab Page work (see GetHistoryURLWithSearchText). BUG=9940 TEST=Verify that searches from the new tab page and from the history page result in the same search query appearing in the history results page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13938

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	chrome/browser/resources/history.html	View		2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages