Add a TabModelBase#closeAllTabs() that supports undo

Add a closeAllTabs() that supports undo

BUG=268157
Committed: https://crrev.com/3f44910d9bc4cd22474122c87c460ce299f1adf6
Cr-Commit-Position: refs/heads/master@{#300541}

[Theresa, 2014-10-21 17:40:05]

twellington@chromium.org changed reviewers:
+ dtrainor@chromium.org, tedchoc@chromium.org

[Theresa, 2014-10-21 17:40:05]

This is a small change to enable closing all tabs in a way that is undo-able and
does not create notifications for "tab pending closure".

[David Trainor- moved to gerrit, 2014-10-21 17:45:16]

lgtm

https://codereview.chromium.org/672463002/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java
(right):

https://codereview.chromium.org/672463002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java:300:
*               {@code true} and {@link #supportsPendingClosures()} is {@code
true},
And canUndo is true also?

https://codereview.chromium.org/672463002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java:301:
*               observers will be notified of the pending closure.
It might be good to mention that observers will still be notified of
CLOSURE_COMMITTED/CANCELLED even if they're not notified of a pending closure to
start with.

https://codereview.chromium.org/672463002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java:316:
notify &= supportsPendingClosures();
This should probably be notify &= canUndo (you don't need
supportsPendingClosures() if you do that because canUndo already &='s it).

Alternatively you can change the below if statement to if (notify && canUndo).

[Theresa, 2014-10-21 18:05:26]

https://codereview.chromium.org/672463002/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java
(right):

https://codereview.chromium.org/672463002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java:300:
*               {@code true} and {@link #supportsPendingClosures()} is {@code
true},
On 2014/10/21 17:45:16, David Trainor wrote:
> And canUndo is true also?

Done.

https://codereview.chromium.org/672463002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java:301:
*               observers will be notified of the pending closure.
On 2014/10/21 17:45:16, David Trainor wrote:
> It might be good to mention that observers will still be notified of
> CLOSURE_COMMITTED/CANCELLED even if they're not notified of a pending closure
to
> start with.

Done.

https://codereview.chromium.org/672463002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java:316:
notify &= supportsPendingClosures();
On 2014/10/21 17:45:16, David Trainor wrote:
> This should probably be notify &= canUndo (you don't need
> supportsPendingClosures() if you do that because canUndo already &='s it).
> 
> Alternatively you can change the below if statement to if (notify && canUndo).

Done.

[Theresa, 2014-10-21 18:49:29]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2014-10-21 18:49:30]

The CQ bit was unchecked by twellington@chromium.org

[Theresa, 2014-10-21 18:52:08]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2014-10-21 18:52:58]

twellington@chromium.org changed reviewers:
- dtrainor@chromium.org, tedchoc@chromium.org

[Theresa, 2014-10-21 18:52:59]

Committing

[Theresa, 2014-10-21 18:53:10]

The CQ bit was unchecked by twellington@chromium.org

[Theresa, 2014-10-21 18:53:10]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2014-10-21 18:53:57]

twellington@chromium.org changed reviewers:
+ dtrainor@chromium.org

[Theresa, 2014-10-21 18:54:58]

The CQ bit was checked by twellington@chromium.org

[commit-bot: I haz the power, 2014-10-21 18:57:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/672463002/20001

[commit-bot: I haz the power, 2014-10-21 20:03:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-21 20:03:58]

Patchset 2 (id:??) landed as
https://crrev.com/3f44910d9bc4cd22474122c87c460ce299f1adf6
Cr-Commit-Position: refs/heads/master@{#300541}