Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 672433002: [ServiceWorkerCache] QuotaClientMask should handle kServiceWorkerCacheID (Closed)

Created:
6 years, 2 months ago by jkarlin
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorkerCache] QuotaClientMask should handle kServiceWorkerCacheID When removing ServiceWorker data with the QuotaClient we should remove both registrations and cache data. This CL adds the cache data id. BUG=420159 Committed: https://crrev.com/f2afbee8d6d05e394ce45364d34f77c5eccd64ce Cr-Commit-Position: refs/heads/master@{#300712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/browser/storage_partition_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 18 (6 generated)
jkarlin
michael: PTAL since this is for ServiceWorkers and then I'll add an OWNER. Thanks!
6 years, 2 months ago (2014-10-21 15:21:46 UTC) #2
jkarlin
+r jsbell. PTAL, thanks!
6 years, 2 months ago (2014-10-21 15:22:14 UTC) #4
jsbell
lgtm, you'll need an OWNERS review, though.
6 years, 2 months ago (2014-10-21 15:55:51 UTC) #5
jkarlin
sky@chromium.org: Please review changes in all for OWNERS. Thanks!
6 years, 2 months ago (2014-10-21 15:58:35 UTC) #7
sky
I'm not a good owner for this. Can you find another owner?
6 years, 2 months ago (2014-10-21 18:06:06 UTC) #8
jkarlin
On 2014/10/21 18:06:06, sky wrote: > I'm not a good owner for this. Can you ...
6 years, 2 months ago (2014-10-21 18:10:46 UTC) #9
jkarlin
jochen@ - Please review for OWNERS. Thanks!
6 years, 2 months ago (2014-10-21 18:11:18 UTC) #11
jkarlin
On 2014/10/21 18:11:18, jkarlin wrote: > jochen@ - Please review for OWNERS. Thanks! jam@ - ...
6 years, 2 months ago (2014-10-21 18:12:44 UTC) #13
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-22 15:23:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672433002/1
6 years, 2 months ago (2014-10-22 15:24:36 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 18:28:32 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 18:29:43 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2afbee8d6d05e394ce45364d34f77c5eccd64ce
Cr-Commit-Position: refs/heads/master@{#300712}

Powered by Google App Engine
This is Rietveld 408576698