Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 672423003: [ServiceWorker] Add error handling code fetch-mixed-content-iframe.html to avoid timeouts. (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
Reviewers:
falken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, jsbell
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Add error handling code fetch-mixed-content-iframe.html to avoid timeouts. BUG=426047 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184333

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M LayoutTests/http/tests/serviceworker/resources/fetch-mixed-content-iframe.html View 2 chunks +10 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
horo
falken@ Could you please review this? This is same as what jsbell@ suggested in https://code.google.com/p/chromium/issues/detail?id=426047#c2
6 years, 2 months ago (2014-10-24 06:26:20 UTC) #2
falken
lgtm https://codereview.chromium.org/672423003/diff/1/LayoutTests/http/tests/serviceworker/resources/fetch-mixed-content-iframe.html File LayoutTests/http/tests/serviceworker/resources/fetch-mixed-content-iframe.html (right): https://codereview.chromium.org/672423003/diff/1/LayoutTests/http/tests/serviceworker/resources/fetch-mixed-content-iframe.html#newcode52 LayoutTests/http/tests/serviceworker/resources/fetch-mixed-content-iframe.html:52: host_info['HTTP_ORIGIN']); Note that Promises can reject with anything, ...
6 years, 2 months ago (2014-10-24 06:54:54 UTC) #3
horo
Thank you!
6 years, 2 months ago (2014-10-24 06:56:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672423003/1
6 years, 2 months ago (2014-10-24 06:57:17 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 08:01:13 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184333

Powered by Google App Engine
This is Rietveld 408576698