Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc

Issue 672413003: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/translate/translate_bubble_view.h" 5 #include "chrome/browser/ui/views/translate/translate_bubble_view.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "chrome/browser/ui/translate/translate_bubble_model.h" 8 #include "chrome/browser/ui/translate/translate_bubble_model.h"
9 #include "chrome/browser/ui/translate/translate_bubble_view_state_transition.h" 9 #include "chrome/browser/ui/translate/translate_bubble_view_state_transition.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 14 matching lines...) Expand all
25 never_translate_language_(false), 25 never_translate_language_(false),
26 never_translate_site_(false), 26 never_translate_site_(false),
27 should_always_translate_(false), 27 should_always_translate_(false),
28 set_always_translate_called_count_(0), 28 set_always_translate_called_count_(0),
29 translate_called_(false), 29 translate_called_(false),
30 revert_translation_called_(false), 30 revert_translation_called_(false),
31 translation_declined_called_(false), 31 translation_declined_called_(false),
32 original_language_index_on_translation_(-1), 32 original_language_index_on_translation_(-1),
33 target_language_index_on_translation_(-1) {} 33 target_language_index_on_translation_(-1) {}
34 34
35 virtual TranslateBubbleModel::ViewState GetViewState() const override { 35 TranslateBubbleModel::ViewState GetViewState() const override {
36 return view_state_transition_.view_state(); 36 return view_state_transition_.view_state();
37 } 37 }
38 38
39 virtual void SetViewState(TranslateBubbleModel::ViewState view_state) 39 void SetViewState(TranslateBubbleModel::ViewState view_state) override {
40 override {
41 view_state_transition_.SetViewState(view_state); 40 view_state_transition_.SetViewState(view_state);
42 } 41 }
43 42
44 virtual void ShowError(translate::TranslateErrors::Type error_type) override { 43 void ShowError(translate::TranslateErrors::Type error_type) override {
45 error_type_ = error_type; 44 error_type_ = error_type;
46 } 45 }
47 46
48 virtual void GoBackFromAdvanced() override { 47 void GoBackFromAdvanced() override {
49 view_state_transition_.GoBackFromAdvanced(); 48 view_state_transition_.GoBackFromAdvanced();
50 } 49 }
51 50
52 virtual int GetNumberOfLanguages() const override { 51 int GetNumberOfLanguages() const override { return 1000; }
53 return 1000;
54 }
55 52
56 virtual base::string16 GetLanguageNameAt(int index) const override { 53 base::string16 GetLanguageNameAt(int index) const override {
57 return base::string16(); 54 return base::string16();
58 } 55 }
59 56
60 virtual int GetOriginalLanguageIndex() const override { 57 int GetOriginalLanguageIndex() const override {
61 return original_language_index_; 58 return original_language_index_;
62 } 59 }
63 60
64 virtual void UpdateOriginalLanguageIndex(int index) override { 61 void UpdateOriginalLanguageIndex(int index) override {
65 original_language_index_ = index; 62 original_language_index_ = index;
66 } 63 }
67 64
68 virtual int GetTargetLanguageIndex() const override { 65 int GetTargetLanguageIndex() const override { return target_language_index_; }
69 return target_language_index_;
70 }
71 66
72 virtual void UpdateTargetLanguageIndex(int index) override { 67 void UpdateTargetLanguageIndex(int index) override {
73 target_language_index_ = index; 68 target_language_index_ = index;
74 } 69 }
75 70
76 virtual void SetNeverTranslateLanguage(bool value) override { 71 void SetNeverTranslateLanguage(bool value) override {
77 never_translate_language_ = value; 72 never_translate_language_ = value;
78 } 73 }
79 74
80 virtual void SetNeverTranslateSite(bool value) override { 75 void SetNeverTranslateSite(bool value) override {
81 never_translate_site_ = value; 76 never_translate_site_ = value;
82 } 77 }
83 78
84 virtual bool ShouldAlwaysTranslate() const override { 79 bool ShouldAlwaysTranslate() const override {
85 return should_always_translate_; 80 return should_always_translate_;
86 } 81 }
87 82
88 virtual void SetAlwaysTranslate(bool value) override { 83 void SetAlwaysTranslate(bool value) override {
89 should_always_translate_ = value; 84 should_always_translate_ = value;
90 set_always_translate_called_count_++; 85 set_always_translate_called_count_++;
91 } 86 }
92 87
93 virtual void Translate() override { 88 void Translate() override {
94 translate_called_ = true; 89 translate_called_ = true;
95 original_language_index_on_translation_ = original_language_index_; 90 original_language_index_on_translation_ = original_language_index_;
96 target_language_index_on_translation_ = target_language_index_; 91 target_language_index_on_translation_ = target_language_index_;
97 } 92 }
98 93
99 virtual void RevertTranslation() override { 94 void RevertTranslation() override { revert_translation_called_ = true; }
100 revert_translation_called_ = true;
101 }
102 95
103 virtual void TranslationDeclined(bool explicitly_closed) override { 96 void TranslationDeclined(bool explicitly_closed) override {
104 translation_declined_called_ = true; 97 translation_declined_called_ = true;
105 } 98 }
106 99
107 virtual bool IsPageTranslatedInCurrentLanguages() const override { 100 bool IsPageTranslatedInCurrentLanguages() const override {
108 return original_language_index_on_translation_ == 101 return original_language_index_on_translation_ ==
109 original_language_index_ && 102 original_language_index_ &&
110 target_language_index_on_translation_ == target_language_index_; 103 target_language_index_on_translation_ == target_language_index_;
111 } 104 }
112 105
113 TranslateBubbleViewStateTransition view_state_transition_; 106 TranslateBubbleViewStateTransition view_state_transition_;
114 translate::TranslateErrors::Type error_type_; 107 translate::TranslateErrors::Type error_type_;
115 int original_language_index_; 108 int original_language_index_;
116 int target_language_index_; 109 int target_language_index_;
117 bool never_translate_language_; 110 bool never_translate_language_;
118 bool never_translate_site_; 111 bool never_translate_site_;
119 bool should_always_translate_; 112 bool should_always_translate_;
120 int set_always_translate_called_count_; 113 int set_always_translate_called_count_;
121 bool translate_called_; 114 bool translate_called_;
122 bool revert_translation_called_; 115 bool revert_translation_called_;
123 bool translation_declined_called_; 116 bool translation_declined_called_;
124 int original_language_index_on_translation_; 117 int original_language_index_on_translation_;
125 int target_language_index_on_translation_; 118 int target_language_index_on_translation_;
126 }; 119 };
127 120
128 } // namespace 121 } // namespace
129 122
130 class TranslateBubbleViewTest : public views::ViewsTestBase { 123 class TranslateBubbleViewTest : public views::ViewsTestBase {
131 public: 124 public:
132 TranslateBubbleViewTest() { 125 TranslateBubbleViewTest() {
133 } 126 }
134 127
135 protected: 128 protected:
136 virtual void SetUp() override { 129 void SetUp() override {
137 views::ViewsTestBase::SetUp(); 130 views::ViewsTestBase::SetUp();
138 131
139 // The bubble needs the parent as an anchor. 132 // The bubble needs the parent as an anchor.
140 views::Widget::InitParams params = 133 views::Widget::InitParams params =
141 CreateParams(views::Widget::InitParams::TYPE_WINDOW); 134 CreateParams(views::Widget::InitParams::TYPE_WINDOW);
142 params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET; 135 params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
143 136
144 anchor_widget_.reset(new views::Widget()); 137 anchor_widget_.reset(new views::Widget());
145 anchor_widget_->Init(params); 138 anchor_widget_->Init(params);
146 anchor_widget_->Show(); 139 anchor_widget_->Show();
147 140
148 mock_model_ = new MockTranslateBubbleModel( 141 mock_model_ = new MockTranslateBubbleModel(
149 TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE); 142 TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE);
150 scoped_ptr<TranslateBubbleModel> model(mock_model_); 143 scoped_ptr<TranslateBubbleModel> model(mock_model_);
151 bubble_ = new TranslateBubbleView(anchor_widget_->GetContentsView(), 144 bubble_ = new TranslateBubbleView(anchor_widget_->GetContentsView(),
152 model.Pass(), 145 model.Pass(),
153 translate::TranslateErrors::NONE, 146 translate::TranslateErrors::NONE,
154 NULL); 147 NULL);
155 views::BubbleDelegateView::CreateBubble(bubble_)->Show(); 148 views::BubbleDelegateView::CreateBubble(bubble_)->Show();
156 } 149 }
157 150
158 virtual void TearDown() override { 151 void TearDown() override {
159 bubble_->GetWidget()->CloseNow(); 152 bubble_->GetWidget()->CloseNow();
160 anchor_widget_.reset(); 153 anchor_widget_.reset();
161 154
162 views::ViewsTestBase::TearDown(); 155 views::ViewsTestBase::TearDown();
163 } 156 }
164 157
165 scoped_ptr<views::Widget> anchor_widget_; 158 scoped_ptr<views::Widget> anchor_widget_;
166 MockTranslateBubbleModel* mock_model_; 159 MockTranslateBubbleModel* mock_model_;
167 TranslateBubbleView* bubble_; 160 TranslateBubbleView* bubble_;
168 }; 161 };
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 312
320 TEST_F(TranslateBubbleViewTest, CancelButtonReturningError) { 313 TEST_F(TranslateBubbleViewTest, CancelButtonReturningError) {
321 bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ERROR); 314 bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ERROR);
322 bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ADVANCED); 315 bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ADVANCED);
323 316
324 // Click the "Cancel" button to go back. 317 // Click the "Cancel" button to go back.
325 EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_ADVANCED, bubble_->GetViewState()); 318 EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_ADVANCED, bubble_->GetViewState());
326 bubble_->HandleButtonPressed(TranslateBubbleView::BUTTON_ID_CANCEL); 319 bubble_->HandleButtonPressed(TranslateBubbleView::BUTTON_ID_CANCEL);
327 EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_ERROR, bubble_->GetViewState()); 320 EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_ERROR, bubble_->GetViewState());
328 } 321 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698