Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 672403002: Cleanup: Remove most enable_extensions logic in extensions code. (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 1 month ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove most enable_extensions logic in extensions code. They are no longer needed since nearly no extensions code gets built when extensions are disabled. Committed: https://crrev.com/da556afcb3defaa2c929797dbe09711d04279b79 Cr-Commit-Position: refs/heads/master@{#302369}

Patch Set 1 : #

Patch Set 2 : fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -141 lines) Patch
M extensions/BUILD.gn View 3 chunks +2 lines, -6 lines 0 comments Download
M extensions/browser/api/api_registration.gyp View 1 chunk +3 lines, -9 lines 0 comments Download
M extensions/common/api/BUILD.gn View 2 chunks +9 lines, -8 lines 0 comments Download
M extensions/common/api/schemas.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/api/schemas.gypi View 2 chunks +1 line, -19 lines 0 comments Download
M extensions/common/common_manifest_handlers.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/common/permissions/usb_device_permission.cc View 3 chunks +1 line, -8 lines 0 comments Download
M extensions/common/permissions/usb_device_permission_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M extensions/extensions.gyp View 1 4 chunks +9 lines, -41 lines 0 comments Download
M extensions/extensions_resources.gyp View 2 chunks +3 lines, -7 lines 0 comments Download
M extensions/renderer/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 7 chunks +5 lines, -14 lines 0 comments Download
M extensions/renderer/dom_activity_logger.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/renderer/messaging_bindings.cc View 4 chunks +1 line, -8 lines 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_browser_main_parts.cc View 4 chunks +1 line, -8 lines 0 comments Download
M extensions/strings/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Lei Zhang
6 years, 1 month ago (2014-10-31 23:34:40 UTC) #7
Yoyo Zhou
lgtm!
6 years, 1 month ago (2014-10-31 23:58:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672403002/120001
6 years, 1 month ago (2014-11-01 00:09:57 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:120001)
6 years, 1 month ago (2014-11-01 00:51:45 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 00:52:48 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/da556afcb3defaa2c929797dbe09711d04279b79
Cr-Commit-Position: refs/heads/master@{#302369}

Powered by Google App Engine
This is Rietveld 408576698