Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 672393004: Restore "caps lock" keyboard settings dropdown. (Closed)

Created:
6 years, 1 month ago by Evan Stade
Modified:
6 years, 1 month ago
Reviewers:
michaelpg
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Restore "caps lock" keyboard settings dropdown. BUG=424610 Committed: https://crrev.com/15a1352e80b9797075109726b4e514727c43ca3c Cr-Commit-Position: refs/heads/master@{#301574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/options/chromeos/keyboard_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
6 years, 1 month ago (2014-10-27 21:55:01 UTC) #2
michaelpg
lgtm
6 years, 1 month ago (2014-10-27 21:56:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672393004/1
6 years, 1 month ago (2014-10-27 23:20:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 06:23:05 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 06:24:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15a1352e80b9797075109726b4e514727c43ca3c
Cr-Commit-Position: refs/heads/master@{#301574}

Powered by Google App Engine
This is Rietveld 408576698