LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/scope-default.html - Issue 672383003: [ServiceWorker] Don't allow registration of the ServiceWorker scope outside the script directory.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/scope-default.html

Issue 672383003: [ServiceWorker] Don't allow registration of the ServiceWorker scope outside the script directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: geofencing/apis_not_implemented.html Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/scope-absolute-url.html ('k') | LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/scope-relative-path.html » ('j') | Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>ServiceWorkerGlobalScope: scope property is default value</title>	2 <title>ServiceWorkerGlobalScope: scope property is default value</title>

3 <script src="../../resources/testharness.js"></script>	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharness-helpers.js"></script>

4 <script src="../../resources/testharnessreport.js"></script>	5 <script src="../../resources/testharnessreport.js"></script>

5 <script src="../resources/test-helpers.js"></script>	6 <script src="../resources/test-helpers.js"></script>

6 <script src="resources/scope.js"></script>	7 <script src="resources/scope.js"></script>

7 <script>	8 <script>

8 async_test(function(t) {	9

9 scope_test(t, 'resources/scope-worker.js');	10 promise_test(function(t) {

10 }, 'Verify the scope property: default scope');	11 return assert_promise_rejects(

	12 navigator.serviceWorker.register('resources/scope-worker.js'),

	13 'SecurityError',

	14 'Registration default scope should fail with SecurityError.');

	15 }, 'Registering default scope');
	falken 2014/10/24 06:50:44 This test should have a better name. "Register a s This test should have a better name. "Register a script not in the root directory for the default scope" We also now lose the test coverage of scope_test for a default scope. But I think now it's impossible unless we put the script in LayoutTest/http/tests. horo 2014/10/24 07:21:43 Done. Show quoted text On 2014/10/24 06:50:44, falken wrote: > This test should have a better name. "Register a script not in the root > directory for the default scope" > > We also now lose the test coverage of scope_test for a default scope. But I > think now it's impossible unless we put the script in LayoutTest/http/tests. Done.
11 </script>	16 </script>

OLD	NEW