Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: sky/tools/skydb

Issue 672383002: Add --gdb argument to skydb (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/skydb
diff --git a/sky/tools/skydb b/sky/tools/skydb
index 5b3732fb20d86e8f089b534d5837133c86149f43..83aeb016ffc001679c549e7ca1eff3b36d12cf1c 100755
--- a/sky/tools/skydb
+++ b/sky/tools/skydb
@@ -3,6 +3,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import argparse
import os
import subprocess
import sys
@@ -32,7 +33,12 @@ def start_http_server_for_file(path):
return 'http://localhost:%s/%s' % (HTTP_PORT, os.path.basename(path))
-def main(args):
+def main():
+ parser = argparse.ArgumentParser(description='Sky launcher/debugger')
+ parser.add_argument('--gdb', action='store_true')
+ parser.add_argument('url', nargs='?', type=str)
+ args = parser.parse_args()
+
content_handlers = ['%s,%s' % (mime_type, 'mojo://sky_viewer/')
for mime_type in SUPPORTED_MIME_TYPES]
shell_command = [
@@ -42,16 +48,19 @@ def main(args):
'--url-mappings=mojo:window_manager=mojo:sky_debugger',
'mojo:window_manager',
]
- if args:
- url = args[0]
- parse_result = urlparse.urlparse(url)
- if not parse_result.scheme:
+ if args.url:
+ url = args.url
+ if not urlparse.urlparse(url).scheme:
url = start_http_server_for_file(url)
prompt_args = '--args-for=mojo://sky_debugger_prompt/ %s' % url
shell_command.append(prompt_args)
+ if args.gdb:
+ shell_command = ['gdb', '--args'] + shell_command
+
+ print ' '.join(shell_command)
subprocess.check_call(shell_command)
if __name__ == '__main__':
- main(sys.argv[1:])
+ main()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698