Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 672343002: Add UseCounter for RenderRuby (Closed)

Created:
6 years, 2 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 2 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Add UseCounter for RenderRuby I'm curious how common Ruby really is, as it adds complexity to Line Layout. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderRuby.cpp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
leviw_travelin_and_unemployed
6 years, 2 months ago (2014-10-23 21:14:23 UTC) #2
pdr.
On 2014/10/23 at 21:14:23, leviw wrote: > Do we need to usecount RenderRubyRun and RenderRubyText ...
6 years, 2 months ago (2014-10-23 21:17:19 UTC) #3
leviw_travelin_and_unemployed
On 2014/10/23 at 21:17:19, pdr wrote: > On 2014/10/23 at 21:14:23, leviw wrote: > > ...
6 years, 2 months ago (2014-10-23 21:49:47 UTC) #4
pdr.
On 2014/10/23 at 21:49:47, leviw wrote: > On 2014/10/23 at 21:17:19, pdr wrote: > > ...
6 years, 2 months ago (2014-10-23 21:51:29 UTC) #5
leviw_travelin_and_unemployed
Cool thanks!
6 years, 2 months ago (2014-10-23 22:56:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672343002/1
6 years, 2 months ago (2014-10-23 22:58:53 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 00:11:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184316

Powered by Google App Engine
This is Rietveld 408576698