Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/objects-debug.cc

Issue 67233002: Revert "Reland [Object.observe] Don't force normalization of elements for observed objects" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 CHECK(instance_size() == kVariableSizeSentinel || 359 CHECK(instance_size() == kVariableSizeSentinel ||
360 (kPointerSize <= instance_size() && 360 (kPointerSize <= instance_size() &&
361 instance_size() < heap->Capacity())); 361 instance_size() < heap->Capacity()));
362 VerifyHeapPointer(prototype()); 362 VerifyHeapPointer(prototype());
363 VerifyHeapPointer(instance_descriptors()); 363 VerifyHeapPointer(instance_descriptors());
364 SLOW_ASSERT(instance_descriptors()->IsSortedNoDuplicates()); 364 SLOW_ASSERT(instance_descriptors()->IsSortedNoDuplicates());
365 if (HasTransitionArray()) { 365 if (HasTransitionArray()) {
366 SLOW_ASSERT(transitions()->IsSortedNoDuplicates()); 366 SLOW_ASSERT(transitions()->IsSortedNoDuplicates());
367 SLOW_ASSERT(transitions()->IsConsistentWithBackPointers(this)); 367 SLOW_ASSERT(transitions()->IsConsistentWithBackPointers(this));
368 } 368 }
369 ASSERT(!is_observed() || instance_type() < FIRST_JS_OBJECT_TYPE ||
370 instance_type() > LAST_JS_OBJECT_TYPE ||
371 has_slow_elements_kind() || has_external_array_elements());
369 } 372 }
370 373
371 374
372 void Map::SharedMapVerify() { 375 void Map::SharedMapVerify() {
373 MapVerify(); 376 MapVerify();
374 CHECK(is_shared()); 377 CHECK(is_shared());
375 CHECK(instance_descriptors()->IsEmpty()); 378 CHECK(instance_descriptors()->IsEmpty());
376 CHECK_EQ(0, pre_allocated_property_fields()); 379 CHECK_EQ(0, pre_allocated_property_fields());
377 CHECK_EQ(0, unused_property_fields()); 380 CHECK_EQ(0, unused_property_fields());
378 CHECK_EQ(StaticVisitorBase::GetVisitorId(instance_type(), instance_size()), 381 CHECK_EQ(StaticVisitorBase::GetVisitorId(instance_type(), instance_size()),
(...skipping 817 matching lines...) Expand 10 before | Expand all | Expand 10 after
1196 for (int i = 0; i < number_of_transitions(); ++i) { 1199 for (int i = 0; i < number_of_transitions(); ++i) {
1197 if (!CheckOneBackPointer(current_map, GetTarget(i))) return false; 1200 if (!CheckOneBackPointer(current_map, GetTarget(i))) return false;
1198 } 1201 }
1199 return true; 1202 return true;
1200 } 1203 }
1201 1204
1202 1205
1203 #endif // DEBUG 1206 #endif // DEBUG
1204 1207
1205 } } // namespace v8::internal 1208 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698