src/objects.cc - Issue 672323003: Widen definition of %HasComplexElements() to include non-enumerability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 672323003: Widen definition of %HasComplexElements() to include non-enumerability (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Rename test Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 3d18e3d8acb54503d51f913c375bac97d50a9a8a..81eec5e3df5cf87ec111ee876bc222f5881f2c63 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -15295,7 +15295,7 @@ bool Dictionary<Derived, Shape, Key>::HasComplexElements() {

if (details.IsDeleted()) continue;

if (details.type() == CALLBACKS) return true;

PropertyAttributes attr = details.attributes();

- if (attr & (READ_ONLY | DONT_DELETE)) return true;

+ if (attr & (READ_ONLY | DONT_DELETE | DONT_ENUM)) return true;

}

return false;

« no previous file with comments | « src/objects.h ('k') | test/mjsunit/regress/regress-shift-enumerable.js » ('j') | no next file with comments »