Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: src/objects.cc

Issue 672323003: Widen definition of %HasComplexElements() to include non-enumerability (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 4359f1738577a0fc8c449d8efecaafdbe16f4bdd..af80ce2c977ecec8238ab0dce82000fcf4b6296f 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -15274,7 +15274,7 @@ bool Dictionary<Derived, Shape, Key>::HasComplexElements() {
if (details.IsDeleted()) continue;
if (details.type() == CALLBACKS) return true;
PropertyAttributes attr = details.attributes();
- if (attr & (READ_ONLY | DONT_DELETE)) return true;
+ if (attr & (READ_ONLY | DONT_DELETE | DONT_ENUM)) return true;
}
}
return false;

Powered by Google App Engine
This is Rietveld 408576698