Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 672323003: Widen definition of %HasComplexElements() to include non-enumerability (Closed)

Created:
6 years, 2 months ago by adamk
Modified:
6 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Widen definition of %HasComplexElements() to include non-enumerability This avoids using the Sparse methods on objects with non-enumerable elements, which can cause the 'enumerable: false' bit to get lost in the operation. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24883

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M src/objects.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-shift-enumerable.js View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
adamk
Quick followup to HasComplexElements().
6 years, 2 months ago (2014-10-23 23:56:23 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/672323003/diff/1/test/mjsunit/regress/regress-enumerable-element.js File test/mjsunit/regress/regress-enumerable-element.js (right): https://codereview.chromium.org/672323003/diff/1/test/mjsunit/regress/regress-enumerable-element.js#newcode1 test/mjsunit/regress/regress-enumerable-element.js:1: // Copyright 2014 the V8 project authors. All ...
6 years, 2 months ago (2014-10-24 17:04:08 UTC) #3
adamk
https://codereview.chromium.org/672323003/diff/1/test/mjsunit/regress/regress-enumerable-element.js File test/mjsunit/regress/regress-enumerable-element.js (right): https://codereview.chromium.org/672323003/diff/1/test/mjsunit/regress/regress-enumerable-element.js#newcode1 test/mjsunit/regress/regress-enumerable-element.js:1: // Copyright 2014 the V8 project authors. All rights ...
6 years, 2 months ago (2014-10-24 18:03:45 UTC) #4
adamk
6 years, 2 months ago (2014-10-24 18:04:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24883 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698