Issue 672313002: Adds ApplicationRunnerChromium::Quit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 672313002: Adds ApplicationRunnerChromium::Quit. (Closed)

Created:
6 years, 1 month ago by sky

Modified:
6 years, 1 month ago

Reviewers:
DaveMoore

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Visibility:
Public.

More Reviews

Description

Adds ApplicationRunnerChromium::Quit. Used to quit the run loop started by Run(). BUG=none TEST=none R=davemoore@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1d0ff6e21ab5cb598ca247d5fde874b598c1ae99

Patch Set 1 #

Patch Set 2 : order #

Patch Set 3 : attempt 2 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	mojo/public/cpp/application/application_impl.h	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

The problem motivating this patch is that it's unsafe to invoke MessageLoop::Quit() at random points. ...

6 years, 1 month ago (2014-10-23 19:37:32 UTC) #1

sky

6 years, 1 month ago (2014-10-23 22:22:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
1d0ff6e21ab5cb598ca247d5fde874b598c1ae99 (presubmit successful).

Expand Messages | Collapse Messages