Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 67229: Use different names for Chrome/Chromium for Chrome HTML prog id. If we (Closed)

Created:
11 years, 8 months ago by kuchhal
Modified:
9 years, 7 months ago
Reviewers:
huanr
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Use different names for Chrome/Chromium for Chrome HTML prog id. If we user the same name for both (ChromeHTML) Vista reports that http/https are associated with Chrome as well as Chromium and each treats itself as default browser. Also do some cleanup - instead of trying to update only the Chrome open cmd, go ahead and register the whole browser again (this doesn't change user preferences). BUG=9697

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -29 lines) Patch
M chrome/installer/setup/main.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/installer/setup/setup.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 3 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kuchhal
11 years, 8 months ago (2009-04-16 19:19:39 UTC) #1
huanr
11 years, 8 months ago (2009-04-16 22:59:12 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698