cc: ReadyToDraw notifications.

cc/resources/rasterizer.h

Index: cc/resources/rasterizer.h
diff --git a/cc/resources/rasterizer.h b/cc/resources/rasterizer.h
index 526058c338d01d42ef7fcb56b587f648c8103537..25b88f0776094b3ddaceb3fe6d88f43f1bbc81c1 100644
--- a/cc/resources/rasterizer.h
+++ b/cc/resources/rasterizer.h
@@ -87,7 +87,7 @@ class CC_EXPORT RasterTask : public RasterizerTask {
   ImageDecodeTask::Vector dependencies_;
 };
 
-static const size_t kNumberOfTaskSets = 2;
+static const size_t kNumberOfTaskSets = 3;

[danakj, 2014/10/31 18:41:31]

can you leave a comment here pointing back to the NamedTaskSets as well?

[reveman, 2014/10/31 19:38:51]

That would be a bit of a layer violation but fine for now if you think that's
important.

Btw, if you're adding a comment here, please add "TODO(reveman): Use template
specialization to make it easy for client code to check at compile time that the
number of supported task sets is correct."

[danakj, 2014/10/31 19:40:50]

The fact this number is tied to that enum is the layering violation, I think.
The comment just documents it, I'd like to have a comment so I can understand
what this constant is in the future :)

[reveman, 2014/10/31 20:06:06]

I don't think there's a layering violation here. The Rasterizer interface
provides support for 3 task sets. It's completely up to the client to decide
what to use those for. The client code is broken if it's trying to use more task
sets than this limit. Note that this should ideally be a template parameter to
the Rasterizer class but it was too large of a change to do that in the initial
patch that implemented generic task sets.

[danakj, 2014/10/31 20:45:03]

Well, it only supports 3 because the TileManager wants 3 :) A template parameter
would let the constant live in the right spot, or a const member on the class
you pass to the constructor.

[ernstm, 2014/11/03 22:34:41]

Done. I've added the comment pointing back to TileManager::NamedTaskSet and the
TODO for template specialization.

 typedef size_t TaskSet;
 typedef std::bitset<kNumberOfTaskSets> TaskSetCollection;