Chromium Code Reviews| Index: cc/layers/picture_layer_impl.cc |
| diff --git a/cc/layers/picture_layer_impl.cc b/cc/layers/picture_layer_impl.cc |
| index c3c7ca021104ba5f2468b233838d45beee16c845..1dca132598f66d3891be53c2e6932dab6bae80a3 100644 |
| --- a/cc/layers/picture_layer_impl.cc |
| +++ b/cc/layers/picture_layer_impl.cc |
| @@ -1405,12 +1405,8 @@ bool PictureLayerImpl::HasValidTilePriorities() const { |
| return IsOnActiveOrPendingTree() && IsDrawnRenderSurfaceLayerListMember(); |
| } |
| -bool PictureLayerImpl::AllTilesRequiredForActivationAreReadyToDraw() const { |
| - TRACE_EVENT0("cc", |
| - "PictureLayerImpl::AllTilesRequiredForActivationAreReadyToDraw"); |
| - if (!layer_tree_impl()->IsPendingTree()) |
| - return true; |
| - |
| +bool PictureLayerImpl::AllTilesRequiredAreReadyToDraw( |
| + TileRequirementCheck is_tile_required_callback) const { |
| if (!HasValidTilePriorities()) |
| return true; |
| @@ -1442,11 +1438,9 @@ bool PictureLayerImpl::AllTilesRequiredForActivationAreReadyToDraw() const { |
| // be out of date. It is updated in the raster/eviction iterators. |
| // TODO(vmpstr): Remove the comment once you can't access this information |
| // from the tile. |
| - if (tiling->IsTileRequiredForActivation(tile) && !tile->IsReadyToDraw()) { |
| - TRACE_EVENT_INSTANT0("cc", |
| - "PictureLayerImpl::" |
| - "AllTilesRequiredForActivationAreReadyToDraw not " |
| - "ready to activate", |
| + if ((tiling->*is_tile_required_callback)(tile) && |
| + !tile->IsReadyToDraw()) { |
| + TRACE_EVENT_INSTANT0("cc", "Tile required, but not ready to draw.", |
| TRACE_EVENT_SCOPE_THREAD); |
| return false; |
| } |
| @@ -1456,6 +1450,27 @@ bool PictureLayerImpl::AllTilesRequiredForActivationAreReadyToDraw() const { |
| return true; |
| } |
| +bool PictureLayerImpl::AllTilesRequiredForActivationAreReadyToDraw() const { |
| + TRACE_EVENT0("cc", |
|
danakj
2014/11/07 15:53:52
The equivalent traces were removed from TOT, so yo
ernstm
2014/11/07 18:44:54
Done.
|
| + "PictureLayerImpl::AllTilesRequiredForActivationAreReadyToDraw"); |
| + |
| + if (!layer_tree_impl()->IsPendingTree()) |
| + return true; |
| + |
| + return AllTilesRequiredAreReadyToDraw( |
| + &PictureLayerTiling::IsTileRequiredForActivationIfVisible); |
| +} |
| + |
| +bool PictureLayerImpl::AllTilesRequiredForDrawAreReadyToDraw() const { |
| + TRACE_EVENT0("cc", "PictureLayerImpl::AllTilesRequiredForDrawAreReadyToDraw"); |
|
danakj
2014/11/07 15:53:52
and this.
ernstm
2014/11/07 18:44:54
Done.
|
| + |
| + if (!layer_tree_impl()->IsActiveTree()) |
| + return true; |
| + |
| + return AllTilesRequiredAreReadyToDraw( |
| + &PictureLayerTiling::IsTileRequiredForDrawIfVisible); |
| +} |
| + |
| PictureLayerImpl::LayerRasterTileIterator::LayerRasterTileIterator() |
| : layer_(nullptr), current_stage_(arraysize(stages_)) { |
| } |