cc: ReadyToDraw notifications.

cc/layers/picture_layer_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/picture_layer_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <set>
 
@@ skipping 1387 matching lines @@
 }
 
 bool PictureLayerImpl::IsOnActiveOrPendingTree() const {
   return !layer_tree_impl()->IsRecycleTree();
 }
 
 bool PictureLayerImpl::HasValidTilePriorities() const {
   return IsOnActiveOrPendingTree() && IsDrawnRenderSurfaceLayerListMember();
 }
 
-bool PictureLayerImpl::AllTilesRequiredForActivationAreReadyToDraw() const {
-  TRACE_EVENT0("cc",
-               "PictureLayerImpl::AllTilesRequiredForActivationAreReadyToDraw");
-  if (!layer_tree_impl()->IsPendingTree())
-    return true;
-
+template <typename F>

[vmpstr, 2014/11/03 23:07:00]

nit: I think F == bool (*)(PictureLayerTiling*, const Tile*) in both cases where
this is used, but feel free to leave it as in, I guess.

For bonus points (or extra complexity :P), we can

typedef bool(PictureLayerTiling::*TileRequirementCheck)(const Tile*); 
then take const TileRequirementCheck& is_tile_required (or keep template
<typename F> instead of these two steps),

and pass &PictureLayerTiling::IsTileRequiredForActivationIfVisible or
&PictureLayerTiling::IsTileRequiredForDrawIfVisible, then do

if ((tiling->*is_tile_required_callback)(tile) && !tile->IsReadyToDraw)

thus eliminating the need for the two functions.

*runs to hide* This is probably too complicated, so feel free to ignore all of
it. We could use a lambda here but I don't think those are allowed yet?

[ernstm, 2014/11/04 00:21:55]

Done. This is what I originally wanted to do, but I didn't know about operator
->*. Thanks!

I've dropped the const reference to function pointer and pass the function
pointer by value instead. Does the const reference offer any benefits in this
situation?

+bool PictureLayerImpl::AllTilesRequiredAreReadyToDraw(
+    const F& is_tile_required_callback) const {
   if (!HasValidTilePriorities())
     return true;
 
   if (!tilings_)
     return true;
 
   if (visible_rect_for_tile_priority_.IsEmpty())
     return true;
 
   gfx::Rect rect = GetViewportForTilePriorityInContentSpace();
@@ skipping 11 matching lines @@
       // A null tile (i.e. missing recording) can just be skipped.
       // TODO(vmpstr): Verify this is true if we create tiles in raster
       // iterators.
       if (!tile)
         continue;
 
       // We can't check tile->required_for_activation, because that value might
       // be out of date. It is updated in the raster/eviction iterators.
       // TODO(vmpstr): Remove the comment once you can't access this information
       // from the tile.
-      if (tiling->IsTileRequiredForActivation(tile) && !tile->IsReadyToDraw()) {
-        TRACE_EVENT_INSTANT0("cc",
-                             "PictureLayerImpl::"
-                             "AllTilesRequiredForActivationAreReadyToDraw not "
-                             "ready to activate",
+      if (is_tile_required_callback(tiling, tile) && !tile->IsReadyToDraw()) {
+        TRACE_EVENT_INSTANT0("cc", "Tile required, but not ready to draw.",
                              TRACE_EVENT_SCOPE_THREAD);
         return false;
       }
     }
   }
 
   return true;
 }
 
+namespace {

[vmpstr, 2014/11/03 23:07:00]

nit: I prefer anonymous namespace to be at the top of the file (there is already
a namespace there, I think, it's just a matter of putting these in there). 

[ernstm, 2014/11/04 00:21:55]

Done.

+bool IsTileRequiredForActivationIfVisible(PictureLayerTiling* tiling,
+                                          const Tile* tile) {
+  return tiling->IsTileRequiredForActivationIfVisible(tile);
+}
+
+bool IsTileRequiredForDrawIfVisible(PictureLayerTiling* tiling,
+                                    const Tile* tile) {
+  return tiling->IsTileRequiredForDrawIfVisible(tile);
+}
+}  // namespace
+
+bool PictureLayerImpl::AllTilesRequiredForActivationAreReadyToDraw() const {
+  TRACE_EVENT0("cc",
+               "PictureLayerImpl::AllTilesRequiredForActivationAreReadyToDraw");
+
+  if (!layer_tree_impl()->IsPendingTree())
+    return true;
+
+  return AllTilesRequiredAreReadyToDraw(&IsTileRequiredForActivationIfVisible);
+}
+
+bool PictureLayerImpl::AllTilesRequiredForDrawAreReadyToDraw() const {
+  TRACE_EVENT0("cc", "PictureLayerImpl::AllTilesRequiredForDrawAreReadyToDraw");
+
+  if (!layer_tree_impl()->IsActiveTree())
+    return true;
+
+  return AllTilesRequiredAreReadyToDraw(&IsTileRequiredForDrawIfVisible);
+}
+
 PictureLayerImpl::LayerRasterTileIterator::LayerRasterTileIterator()
     : layer_(nullptr), current_stage_(arraysize(stages_)) {
 }
 
 PictureLayerImpl::LayerRasterTileIterator::LayerRasterTileIterator(
     PictureLayerImpl* layer,
     bool prioritize_low_res)
     : layer_(layer), current_stage_(0) {
   DCHECK(layer_);
 
@@ skipping 253 matching lines @@
       PictureLayerTilingSet::TilingRange tiling_range = CurrentTilingRange();
       size_t current_tiling_range_offset = current_tiling_ - tiling_range.start;
       return tiling_range.end - 1 - current_tiling_range_offset;
     }
   }
   NOTREACHED();
   return 0;
 }
 
 }  // namespace cc