cc: ReadyToDraw notifications.

cc/layers/picture_layer_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/picture_layer_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <set>
 
@@ skipping 1341 matching lines @@
 }
 
 bool PictureLayerImpl::IsOnActiveOrPendingTree() const {
   return !layer_tree_impl()->IsRecycleTree();
 }
 
 bool PictureLayerImpl::HasValidTilePriorities() const {
   return IsOnActiveOrPendingTree() && IsDrawnRenderSurfaceLayerListMember();
 }
 
-bool PictureLayerImpl::AllTilesRequiredForActivationAreReadyToDraw() const {
-  TRACE_EVENT0("cc",
-               "PictureLayerImpl::AllTilesRequiredForActivationAreReadyToDraw");
-  if (!layer_tree_impl()->IsPendingTree())
-    return true;
-
+bool PictureLayerImpl::AllTilesRequiredAreReadyToDraw(
+    const base::Callback<bool(PictureLayerTiling* tiling, const Tile*)>&

[danakj, 2014/10/31 17:00:57]

Can you give this callback type a name somewhere, so you don't have to repeat
its definition everywhere like this?

[danakj, 2014/10/31 18:41:31]

ignore this comment :)

+        is_tile_required_callback) const {
   if (!HasValidTilePriorities())
     return true;
 
   if (!tilings_)
     return true;
 
   if (visible_rect_for_tile_priority_.IsEmpty())
     return true;
 
   gfx::Rect rect = GetViewportForTilePriorityInContentSpace();
@@ skipping 11 matching lines @@
       // A null tile (i.e. missing recording) can just be skipped.
       // TODO(vmpstr): Verify this is true if we create tiles in raster
       // iterators.
       if (!tile)
         continue;
 
       // We can't check tile->required_for_activation, because that value might
       // be out of date. It is updated in the raster/eviction iterators.
       // TODO(vmpstr): Remove the comment once you can't access this information
       // from the tile.
-      if (tiling->IsTileRequiredForActivation(tile) && !tile->IsReadyToDraw()) {
+      if (is_tile_required_callback.Run(tiling, tile) &&
+          !tile->IsReadyToDraw()) {
         TRACE_EVENT_INSTANT0("cc",
-                             "PictureLayerImpl::"
-                             "AllTilesRequiredForActivationAreReadyToDraw not "
-                             "ready to activate",
+                             "Tile required, but not ready to draw.",
                              TRACE_EVENT_SCOPE_THREAD);
         return false;
       }
     }
   }
 
   return true;
 }
 
+namespace {
+bool IsTileRequiredForActivationIfVisible(PictureLayerTiling* tiling,
+                                          const Tile* tile) {
+  return tiling->IsTileRequiredForActivationIfVisible(tile);
+}
+
+bool IsTileRequiredForDrawIfVisible(PictureLayerTiling* tiling,
+                                    const Tile* tile) {
+  return tiling->IsTileRequiredForDrawIfVisible(tile);
+}
+}  // namespace
+
+bool PictureLayerImpl::AllTilesRequiredForActivationAreReadyToDraw() const {
+  TRACE_EVENT0("cc",
+               "PictureLayerImpl::AllTilesRequiredForActivationAreReadyToDraw");
+
+  if (!layer_tree_impl()->IsPendingTree())
+    return true;
+
+  return AllTilesRequiredAreReadyToDraw(
+      base::Bind(&IsTileRequiredForActivationIfVisible));

[danakj, 2014/10/31 17:00:57]

this seems like a functor (function pointer) would be better suited for this,
like how STL classes work, than Bind/Callback which is much more heavyweight.

You can templatize the AllTilesRequiredAreReadyToDraw like

template <typename F>
bool AllTilesRequiredAreReadyToDraw(const F& is_tile_required_callback) const {
...
   ... is_tile_required_callback(tiling, tile) ...
...
}


And then just call it like
  return AllTilesRequiredAreReadyToDraw(&IsTileRequiredForActivationIfVisible);

[ernstm, 2014/11/03 22:34:41]

Done.

+}
+
+bool PictureLayerImpl::AllTilesRequiredForDrawAreReadyToDraw() const {
+  TRACE_EVENT0("cc", "PictureLayerImpl::AllTilesRequiredForDrawAreReadyToDraw");
+
+  if (!layer_tree_impl()->IsActiveTree())
+    return true;
+
+  return AllTilesRequiredAreReadyToDraw(
+      base::Bind(&IsTileRequiredForDrawIfVisible));
+}
+
 PictureLayerImpl::LayerRasterTileIterator::LayerRasterTileIterator()
     : layer_(nullptr), current_stage_(arraysize(stages_)) {
 }
 
 PictureLayerImpl::LayerRasterTileIterator::LayerRasterTileIterator(
     PictureLayerImpl* layer,
     bool prioritize_low_res)
     : layer_(layer), current_stage_(0) {
   DCHECK(layer_);
 
@@ skipping 253 matching lines @@
       PictureLayerTilingSet::TilingRange tiling_range = CurrentTilingRange();
       size_t current_tiling_range_offset = current_tiling_ - tiling_range.start;
       return tiling_range.end - 1 - current_tiling_range_offset;
     }
   }
   NOTREACHED();
   return 0;
 }
 
 }  // namespace cc