cc: ReadyToDraw notifications.

cc/layers/picture_layer_impl.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_LAYERS_PICTURE_LAYER_IMPL_H_
 #define CC_LAYERS_PICTURE_LAYER_IMPL_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 133 matching lines @@
 
   virtual size_t GPUMemoryUsageInBytes() const override;
 
   virtual void RunMicroBenchmark(MicroBenchmarkImpl* benchmark) override;
 
   // Functions used by tile manager.
   PictureLayerImpl* GetTwinLayer() { return twin_layer_; }
   bool IsOnActiveOrPendingTree() const;
   // Virtual for testing.
   virtual bool HasValidTilePriorities() const;
+  bool AllTilesRequiredAreReadyToDraw(

[vmpstr, 2014/10/24 18:02:23]

Can you put a comment here explaining what this function does (and what the
parameters are).

Also, I think this can be private.

+      const char* event_name,

[vmpstr, 2014/10/24 18:02:23]

const std::string&?

[ernstm, 2014/10/27 21:13:56]

Removed.

+      const base::Callback<bool(PictureLayerTiling* tiling, const Tile*)>&
+          IsTileRequiredCallback) const;

[vmpstr, 2014/10/24 18:02:23]

this should be named as a variable, not a function.

[ernstm, 2014/10/27 21:13:56]

Done.

+  static bool IsTileRequiredForActivation(PictureLayerTiling* tiling,

[vmpstr, 2014/10/24 18:02:23]

These should be anonymous in the implementation.

[ernstm, 2014/10/27 21:13:56]

Done.

+                                          const Tile* tile);
+  static bool IsTileRequiredForDraw(PictureLayerTiling* tiling,
+                                    const Tile* tile);
   bool AllTilesRequiredForActivationAreReadyToDraw() const;
+  bool AllTilesRequiredForDrawAreReadyToDraw() const;
 
  protected:
   friend class LayerRasterTileIterator;
 
   PictureLayerImpl(LayerTreeImpl* tree_impl, int id);
   PictureLayerTiling* AddTiling(float contents_scale);
   void RemoveTiling(float contents_scale);
   void RemoveAllTilings();
   void SyncFromActiveLayer(const PictureLayerImpl* other);
   void AddTilingsForRasterScale();
@@ skipping 62 matching lines @@
   // frame that has a valid viewport for prioritizing tiles.
   gfx::Rect visible_rect_for_tile_priority_;
 
   friend class PictureLayer;
   DISALLOW_COPY_AND_ASSIGN(PictureLayerImpl);
 };
 
 }  // namespace cc
 
 #endif  // CC_LAYERS_PICTURE_LAYER_IMPL_H_