Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 672273002: Removed simple tests steps from CanvasTest. (Closed)

Created:
6 years, 2 months ago by Rémi Piotaix
Modified:
6 years, 2 months ago
Reviewers:
Justin Novosad, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Removed simple tests steps from CanvasTest. CanvasTest only checks if the state of the different canvas implementations are consistent with the one of the default implementation. Because most of the draw calls are stateless and already tested in GMs the test steps that exercices them are not useful. BUG=skia:3054 Committed: https://skia.googlesource.com/skia/+/ec6e670669659e0db2ae76826da5c1d642a10ce1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M tests/CanvasTest.cpp View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Rémi Piotaix
PTAL
6 years, 2 months ago (2014-10-23 17:32:14 UTC) #2
reed1
lgtm
6 years, 2 months ago (2014-10-23 17:36:44 UTC) #3
Justin Novosad
On 2014/10/23 17:36:44, reed1 wrote: > lgtm lgtm2
6 years, 2 months ago (2014-10-23 17:41:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672273002/1
6 years, 2 months ago (2014-10-23 17:50:10 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 17:59:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as ec6e670669659e0db2ae76826da5c1d642a10ce1

Powered by Google App Engine
This is Rietveld 408576698