Issue 672263002: Revert "Ensure RenderFrameHostImpl's RenderFrameSetupPtr doesn't die too early"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 672263002: Revert "Ensure RenderFrameHostImpl's RenderFrameSetupPtr doesn't die too early" (Closed)

Created:
6 years, 2 months ago by yzshen1

Modified:
6 years, 2 months ago

Reviewers:
blundell

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Ensure RenderFrameHostImpl's RenderFrameSetupPtr doesn't die too early" This reverts commit 235d012e9d23fbcc456a06496b246fb4e05d98d6. Reason: caused compilation failure when compiling content_browser_test_utils: ../../content/browser/frame_host/render_frame_host_impl.h:22:10: fatal error: 'content/common/render_frame_setup.mojom.h' file not found TBR=blundell@chromium.org BUG= Committed: https://crrev.com/e36cf8ec21fc5d441007920dcba8a9b8f28cf7bc Cr-Commit-Position: refs/heads/master@{#300907}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -13 lines)			Patch
	M	content/browser/frame_host/render_frame_host_impl.h	View		2 chunks	+0 lines, -9 lines	0 comments	Download
	M	content/browser/frame_host/render_frame_host_impl.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/e36cf8ec21fc5d441007920dcba8a9b8f28cf7bc Cr-Commit-Position: refs/heads/master@{#300907}

6 years, 2 months ago (2014-10-23 17:17:49 UTC) #1

yzshen1

Committed patchset #1 (id:1) manually as e36cf8ec21fc5d441007920dcba8a9b8f28cf7bc (tree was closed).

6 years, 2 months ago (2014-10-23 17:17:51 UTC) #2

yzshen1

6 years, 2 months ago (2014-10-23 17:21:24 UTC) #3

Message was sent while issue was closed.

On 2014/10/23 17:17:51, yzshen1 wrote:
> Committed patchset #1 (id:1) manually as
> e36cf8ec21fc5d441007920dcba8a9b8f28cf7bc (tree was closed).

I believe the reason is the same as what James described (for a similar failure)
in the thread "Flaky mojo builds on Chromium Win Builders" on mojo-dev. Please
take a look.

Expand Messages | Collapse Messages