Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: third_party/WebKit/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

Issue 67225: Use null for default value of event handler attributes in XMLHttpRequest.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp
===================================================================
--- third_party/WebKit/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp (revision 13799)
+++ third_party/WebKit/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp (working copy)
@@ -68,7 +68,7 @@
v8::Local<v8::Object> v8Listener = listener->getListenerObject();
return v8Listener;
}
- return v8::Undefined();
+ return v8::Null();
}
ACCESSOR_SETTER(XMLHttpRequestOnabort)
@@ -102,7 +102,7 @@
v8::Local<v8::Object> v8Listener = listener->getListenerObject();
return v8Listener;
}
- return v8::Undefined();
+ return v8::Null();
}
ACCESSOR_SETTER(XMLHttpRequestOnerror)
@@ -136,7 +136,7 @@
v8::Local<v8::Object> v8Listener = listener->getListenerObject();
return v8Listener;
}
- return v8::Undefined();
+ return v8::Null();
}
ACCESSOR_SETTER(XMLHttpRequestOnload)
@@ -170,7 +170,7 @@
v8::Local<v8::Object> v8Listener = listener->getListenerObject();
return v8Listener;
}
- return v8::Undefined();
+ return v8::Null();
}
ACCESSOR_SETTER(XMLHttpRequestOnloadstart)
@@ -204,7 +204,7 @@
v8::Local<v8::Object> v8Listener = listener->getListenerObject();
return v8Listener;
}
- return v8::Undefined();
+ return v8::Null();
}
ACCESSOR_SETTER(XMLHttpRequestOnprogress)
@@ -238,7 +238,7 @@
v8::Local<v8::Object> v8Listener = listener->getListenerObject();
return v8Listener;
}
- return v8::Undefined();
+ return v8::Null();
}
ACCESSOR_SETTER(XMLHttpRequestOnreadystatechange)
@@ -432,4 +432,4 @@
return v8::Undefined();
}
-} // namespace WebCore
+} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698