Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: third_party/WebKit/WebCore/bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp

Issue 67225: Use null for default value of event handler attributes in XMLHttpRequest.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 ACCESSOR_GETTER(XMLHttpRequestUploadOnabort) 46 ACCESSOR_GETTER(XMLHttpRequestUploadOnabort)
47 { 47 {
48 INC_STATS("DOM.XMLHttpRequestUpload.onabort._get"); 48 INC_STATS("DOM.XMLHttpRequestUpload.onabort._get");
49 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder()); 49 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder());
50 if (xmlHttpRequestUpload->onabort()) { 50 if (xmlHttpRequestUpload->onabort()) {
51 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener*>(xm lHttpRequestUpload->onabort()); 51 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener*>(xm lHttpRequestUpload->onabort());
52 v8::Local<v8::Object> v8Listener = listener->getListenerObject(); 52 v8::Local<v8::Object> v8Listener = listener->getListenerObject();
53 return v8Listener; 53 return v8Listener;
54 } 54 }
55 return v8::Undefined(); 55 return v8::Null();
56 } 56 }
57 57
58 ACCESSOR_SETTER(XMLHttpRequestUploadOnabort) 58 ACCESSOR_SETTER(XMLHttpRequestUploadOnabort)
59 { 59 {
60 INC_STATS("DOM.XMLHttpRequestUpload.onabort._set"); 60 INC_STATS("DOM.XMLHttpRequestUpload.onabort._set");
61 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder()); 61 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder());
62 if (value->IsNull()) { 62 if (value->IsNull()) {
63 if (xmlHttpRequestUpload->onabort()) { 63 if (xmlHttpRequestUpload->onabort()) {
64 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener* >(xmlHttpRequestUpload->onabort()); 64 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener* >(xmlHttpRequestUpload->onabort());
65 v8::Local<v8::Object> v8Listener = listener->getListenerObject(); 65 v8::Local<v8::Object> v8Listener = listener->getListenerObject();
(...skipping 18 matching lines...) Expand all
84 84
85 ACCESSOR_GETTER(XMLHttpRequestUploadOnerror) 85 ACCESSOR_GETTER(XMLHttpRequestUploadOnerror)
86 { 86 {
87 INC_STATS("DOM.XMLHttpRequestUpload.onerror._get"); 87 INC_STATS("DOM.XMLHttpRequestUpload.onerror._get");
88 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder()); 88 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder());
89 if (xmlHttpRequestUpload->onerror()) { 89 if (xmlHttpRequestUpload->onerror()) {
90 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener*>(xm lHttpRequestUpload->onerror()); 90 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener*>(xm lHttpRequestUpload->onerror());
91 v8::Local<v8::Object> v8Listener = listener->getListenerObject(); 91 v8::Local<v8::Object> v8Listener = listener->getListenerObject();
92 return v8Listener; 92 return v8Listener;
93 } 93 }
94 return v8::Undefined(); 94 return v8::Null();
95 } 95 }
96 96
97 ACCESSOR_SETTER(XMLHttpRequestUploadOnerror) 97 ACCESSOR_SETTER(XMLHttpRequestUploadOnerror)
98 { 98 {
99 INC_STATS("DOM.XMLHttpRequestUpload.onerror._set"); 99 INC_STATS("DOM.XMLHttpRequestUpload.onerror._set");
100 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder()); 100 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder());
101 if (value->IsNull()) { 101 if (value->IsNull()) {
102 if (xmlHttpRequestUpload->onerror()) { 102 if (xmlHttpRequestUpload->onerror()) {
103 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener* >(xmlHttpRequestUpload->onerror()); 103 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener* >(xmlHttpRequestUpload->onerror());
104 v8::Local<v8::Object> v8Listener = listener->getListenerObject(); 104 v8::Local<v8::Object> v8Listener = listener->getListenerObject();
(...skipping 18 matching lines...) Expand all
123 123
124 ACCESSOR_GETTER(XMLHttpRequestUploadOnload) 124 ACCESSOR_GETTER(XMLHttpRequestUploadOnload)
125 { 125 {
126 INC_STATS("DOM.XMLHttpRequestUpload.onload._get"); 126 INC_STATS("DOM.XMLHttpRequestUpload.onload._get");
127 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder()); 127 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder());
128 if (xmlHttpRequestUpload->onload()) { 128 if (xmlHttpRequestUpload->onload()) {
129 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener*>(xm lHttpRequestUpload->onload()); 129 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener*>(xm lHttpRequestUpload->onload());
130 v8::Local<v8::Object> v8Listener = listener->getListenerObject(); 130 v8::Local<v8::Object> v8Listener = listener->getListenerObject();
131 return v8Listener; 131 return v8Listener;
132 } 132 }
133 return v8::Undefined(); 133 return v8::Null();
134 } 134 }
135 135
136 ACCESSOR_SETTER(XMLHttpRequestUploadOnload) 136 ACCESSOR_SETTER(XMLHttpRequestUploadOnload)
137 { 137 {
138 INC_STATS("DOM.XMLHttpRequestUpload.onload._set"); 138 INC_STATS("DOM.XMLHttpRequestUpload.onload._set");
139 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder()); 139 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder());
140 if (value->IsNull()) { 140 if (value->IsNull()) {
141 if (xmlHttpRequestUpload->onload()) { 141 if (xmlHttpRequestUpload->onload()) {
142 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener* >(xmlHttpRequestUpload->onload()); 142 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener* >(xmlHttpRequestUpload->onload());
143 v8::Local<v8::Object> v8Listener = listener->getListenerObject(); 143 v8::Local<v8::Object> v8Listener = listener->getListenerObject();
(...skipping 18 matching lines...) Expand all
162 162
163 ACCESSOR_GETTER(XMLHttpRequestUploadOnloadstart) 163 ACCESSOR_GETTER(XMLHttpRequestUploadOnloadstart)
164 { 164 {
165 INC_STATS("DOM.XMLHttpRequestUpload.onloadstart._get"); 165 INC_STATS("DOM.XMLHttpRequestUpload.onloadstart._get");
166 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder()); 166 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder());
167 if (xmlHttpRequestUpload->onloadstart()) { 167 if (xmlHttpRequestUpload->onloadstart()) {
168 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener*>(xm lHttpRequestUpload->onloadstart()); 168 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener*>(xm lHttpRequestUpload->onloadstart());
169 v8::Local<v8::Object> v8Listener = listener->getListenerObject(); 169 v8::Local<v8::Object> v8Listener = listener->getListenerObject();
170 return v8Listener; 170 return v8Listener;
171 } 171 }
172 return v8::Undefined(); 172 return v8::Null();
173 } 173 }
174 174
175 ACCESSOR_SETTER(XMLHttpRequestUploadOnloadstart) 175 ACCESSOR_SETTER(XMLHttpRequestUploadOnloadstart)
176 { 176 {
177 INC_STATS("DOM.XMLHttpRequestUpload.onloadstart._set"); 177 INC_STATS("DOM.XMLHttpRequestUpload.onloadstart._set");
178 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder()); 178 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder());
179 if (value->IsNull()) { 179 if (value->IsNull()) {
180 if (xmlHttpRequestUpload->onloadstart()) { 180 if (xmlHttpRequestUpload->onloadstart()) {
181 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener* >(xmlHttpRequestUpload->onloadstart()); 181 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener* >(xmlHttpRequestUpload->onloadstart());
182 v8::Local<v8::Object> v8Listener = listener->getListenerObject(); 182 v8::Local<v8::Object> v8Listener = listener->getListenerObject();
(...skipping 18 matching lines...) Expand all
201 201
202 ACCESSOR_GETTER(XMLHttpRequestUploadOnprogress) 202 ACCESSOR_GETTER(XMLHttpRequestUploadOnprogress)
203 { 203 {
204 INC_STATS("DOM.XMLHttpRequestUpload.onprogress._get"); 204 INC_STATS("DOM.XMLHttpRequestUpload.onprogress._get");
205 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder()); 205 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder());
206 if (xmlHttpRequestUpload->onprogress()) { 206 if (xmlHttpRequestUpload->onprogress()) {
207 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener*>(xm lHttpRequestUpload->onprogress()); 207 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener*>(xm lHttpRequestUpload->onprogress());
208 v8::Local<v8::Object> v8Listener = listener->getListenerObject(); 208 v8::Local<v8::Object> v8Listener = listener->getListenerObject();
209 return v8Listener; 209 return v8Listener;
210 } 210 }
211 return v8::Undefined(); 211 return v8::Null();
212 } 212 }
213 213
214 ACCESSOR_SETTER(XMLHttpRequestUploadOnprogress) 214 ACCESSOR_SETTER(XMLHttpRequestUploadOnprogress)
215 { 215 {
216 INC_STATS("DOM.XMLHttpRequestUpload.onprogress._set"); 216 INC_STATS("DOM.XMLHttpRequestUpload.onprogress._set");
217 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder()); 217 XMLHttpRequestUpload* xmlHttpRequestUpload = V8Proxy::ToNativeObject<XMLHttp RequestUpload>(V8ClassIndex::XMLHTTPREQUESTUPLOAD, info.Holder());
218 if (value->IsNull()) { 218 if (value->IsNull()) {
219 if (xmlHttpRequestUpload->onprogress()) { 219 if (xmlHttpRequestUpload->onprogress()) {
220 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener* >(xmlHttpRequestUpload->onprogress()); 220 V8ObjectEventListener* listener = static_cast<V8ObjectEventListener* >(xmlHttpRequestUpload->onprogress());
221 v8::Local<v8::Object> v8Listener = listener->getListenerObject(); 221 v8::Local<v8::Object> v8Listener = listener->getListenerObject();
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 return v8::Undefined(); 282 return v8::Undefined();
283 } 283 }
284 284
285 CALLBACK_FUNC_DECL(XMLHttpRequestUploadDispatchEvent) 285 CALLBACK_FUNC_DECL(XMLHttpRequestUploadDispatchEvent)
286 { 286 {
287 INC_STATS("DOM.XMLHttpRequestUpload.dispatchEvent()"); 287 INC_STATS("DOM.XMLHttpRequestUpload.dispatchEvent()");
288 return throwError(NOT_SUPPORTED_ERR); 288 return throwError(NOT_SUPPORTED_ERR);
289 } 289 }
290 290
291 } // namespace WebCore 291 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698