Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 672233002: ScreenObserver::(Set|Get)UsageStatisticsReporting() are extracted into EulaScreen::Delegate. (Closed)

Created:
6 years, 2 months ago by ygorshenin1
Modified:
6 years, 2 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ScreenObserver::(Set|Get)UsageStatisticsReporting() are extracted into EulaScreen::Delegate. BUG=405876 TEST=existing unit_tests and browser_tests Committed: https://crrev.com/411b8d243e453e587a0aaaa06e7de4038b2d93dc Cr-Commit-Position: refs/heads/master@{#301121}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -27 lines) Patch
M chrome/browser/chromeos/login/screens/device_disabled_screen_unittest.cc View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/screens/eula_screen.h View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/eula_screen.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/screen_observer.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 2 4 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ygorshenin1
6 years, 2 months ago (2014-10-23 15:45:26 UTC) #2
Nikita (slow)
lgtm
6 years, 2 months ago (2014-10-24 14:43:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672233002/20001
6 years, 2 months ago (2014-10-24 14:47:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/4829)
6 years, 2 months ago (2014-10-24 15:17:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672233002/40001
6 years, 2 months ago (2014-10-24 15:40:14 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-24 16:25:06 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 16:25:40 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/411b8d243e453e587a0aaaa06e7de4038b2d93dc
Cr-Commit-Position: refs/heads/master@{#301121}

Powered by Google App Engine
This is Rietveld 408576698