Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 67223002: Use the large pdb workaround on more unittests. (Closed)

Created:
7 years, 1 month ago by Sébastien Marchand
Modified:
7 years, 1 month ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use the large pdb workaround on more unittests. If we don't do this we can't compile these targets in Debug with component='static_library'. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234100

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sébastien Marchand
PTAL.
7 years, 1 month ago (2013-11-08 19:18:51 UTC) #1
robertshield
lgtm
7 years, 1 month ago (2013-11-08 19:34:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/67223002/1
7 years, 1 month ago (2013-11-08 19:36:50 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-08 19:44:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/67223002/1
7 years, 1 month ago (2013-11-08 19:58:39 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-09 04:54:32 UTC) #6
Message was sent while issue was closed.
Change committed as 234100

Powered by Google App Engine
This is Rietveld 408576698