Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 672203003: ScreenContext is moved to components/login. (Closed)

Created:
6 years, 1 month ago by ygorshenin1
Modified:
6 years, 1 month ago
CC:
chromium-reviews, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ScreenContext is moved to components/login. BUG=405876 TEST=existing unit_tests and browser_tests Committed: https://crrev.com/98f956e5159865dd1f61539ff7f9fe01e453ed3c Cr-Commit-Position: refs/heads/master@{#301131}

Patch Set 1 #

Patch Set 2 : Added BUILD.gn file. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -779 lines) Patch
M chrome/browser/chromeos/login/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/base_screen.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/base_screen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/controller_pairing_screen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/controller_pairing_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/host_pairing_screen.h View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/login/screens/screen_context.h View 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/browser/chromeos/login/screens/screen_context.cc View 1 chunk +0 lines, -177 lines 0 comments Download
D chrome/browser/chromeos/login/screens/screen_context_unittest.cc View 1 chunk +0 lines, -157 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/base_screen_handler.h View 9 chunks +18 lines, -16 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/login/base_screen_handler_utils.h View 1 chunk +0 lines, -128 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/login/base_screen_handler_utils.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M components/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M components/components.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
A components/login.gypi View 1 chunk +22 lines, -0 lines 0 comments Download
A + components/login/BUILD.gn View 1 1 chunk +11 lines, -8 lines 0 comments Download
A + components/login/OWNERS View 1 chunk +5 lines, -5 lines 0 comments Download
A + components/login/base_screen_handler_utils.h View 8 chunks +37 lines, -38 lines 0 comments Download
A + components/login/base_screen_handler_utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A components/login/login_export.h View 1 chunk +34 lines, -0 lines 0 comments Download
A + components/login/screens/screen_context.h View 4 chunks +8 lines, -7 lines 0 comments Download
A + components/login/screens/screen_context.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/login/screens/screen_context_unittest.cc View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
ygorshenin1
6 years, 1 month ago (2014-10-23 18:32:01 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 1 month ago (2014-10-24 11:39:46 UTC) #3
Nikita (slow)
lgtm
6 years, 1 month ago (2014-10-24 14:41:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672203003/40001
6 years, 1 month ago (2014-10-24 14:45:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/73165) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/15953) ios_rel_device_ninja ...
6 years, 1 month ago (2014-10-24 14:51:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672203003/60001
6 years, 1 month ago (2014-10-24 16:16:42 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-10-24 17:22:29 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 17:23:09 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/98f956e5159865dd1f61539ff7f9fe01e453ed3c
Cr-Commit-Position: refs/heads/master@{#301131}

Powered by Google App Engine
This is Rietveld 408576698