Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 672183003: Add the Blink APIs for the WebNotificationManager. (Closed)

Created:
6 years, 2 months ago by Peter Beverloo
Modified:
6 years, 2 months ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

Add the Blink APIs for the WebNotificationManager. The WebNotificationManager is analogous to the WebNotificationPresenter living in public/web/, but without any dependency on RenderView or RenderFrames. It also splits up the concept of the data associated with a notification and the delegate allowing the embedder to interact with it, as it will soon become possible for the embedder to trigger creation of Notification objects as well (for event delivery in Service Workers). BUG=392187 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184306

Patch Set 1 #

Patch Set 2 : add file comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -2 lines) Patch
M public/platform/Platform.h View 2 chunks +2 lines, -2 lines 0 comments Download
A public/platform/WebNotificationData.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A public/platform/WebNotificationDelegate.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
A public/platform/WebNotificationManager.h View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Peter Beverloo
PTAL Full patches which I'm splitting up can be seen here: Blink: https://codereview.chromium.org/624033003/ Chromium: https://codereview.chromium.org/626973002/
6 years, 2 months ago (2014-10-23 13:55:11 UTC) #2
Mike West
Makes sense to me. Thanks for putting together a design doc. Have you shared it ...
6 years, 2 months ago (2014-10-23 14:03:10 UTC) #3
Peter Beverloo
On 2014/10/23 14:03:10, Mike West wrote: > Makes sense to me. Thanks for putting together ...
6 years, 2 months ago (2014-10-23 16:35:20 UTC) #4
Mike West
On 2014/10/23 16:35:20, Peter Beverloo wrote: > On 2014/10/23 14:03:10, Mike West wrote: > > ...
6 years, 2 months ago (2014-10-23 16:42:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672183003/20001
6 years, 2 months ago (2014-10-23 21:52:29 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 22:57:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184306

Powered by Google App Engine
This is Rietveld 408576698