Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 672183002: Simplify SnapshotReader::LookupInternalClass. (Closed)

Created:
6 years, 2 months ago by Florian Schneider
Modified:
6 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Simplify SnapshotReader::LookupInternalClass. All callers of this function assert that the returned RawClass is non-null. Also, the returned Class is only used to extract its class id. I removed the unreachable code and simplified it accordingly to just return the class id directly. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M runtime/vm/snapshot.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/snapshot.cc View 5 chunks +12 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
6 years, 2 months ago (2014-10-23 11:16:25 UTC) #2
siva
lgtm
6 years, 2 months ago (2014-10-23 17:18:42 UTC) #3
Florian Schneider
6 years, 2 months ago (2014-10-24 09:37:08 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as r41277 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698