Source/core/html/HTMLInputElement.h - Issue 672163002: Fix bug where form/fieldset :valid/:invalid won't be recalculated upon control's willValidate change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.h

Issue 672163002: Fix bug where form/fieldset :valid/:invalid won't be recalculated upon control's willValidate change Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add layout tests to catch the problem Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLInputElement.h

diff --git a/Source/core/html/HTMLInputElement.h b/Source/core/html/HTMLInputElement.h

index 5fccef09af19c9d5bfd346d4373ea7bb0b392cc5..fd7fc323dbea03b64d21c855e7a41cbee68d4187 100644

--- a/Source/core/html/HTMLInputElement.h

+++ b/Source/core/html/HTMLInputElement.h

@@ -264,7 +264,7 @@ private:

virtual void willAddFirstAuthorShadowRoot() override final;

virtual void willChangeForm() override final;

- virtual void didChangeForm() override final;

+ virtual void didChangeForm(HTMLFormElement* oldForm) override final;

virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;

virtual void removedFrom(ContainerNode*) override final;

virtual void didMoveToNewDocument(Document& oldDocument) override final;

« Source/core/html/HTMLFormControlElement.cpp ('K') | « Source/core/html/HTMLFormElement.cpp ('k') | Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »