Source/core/html/HTMLFormElement.h - Issue 672163002: Fix bug where form/fieldset :valid/:invalid won't be recalculated upon control's willValidate change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormElement.h

Issue 672163002: Fix bug where form/fieldset :valid/:invalid won't be recalculated upon control's willValidate change Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add layout tests to catch the problem Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLFormElement.h

diff --git a/Source/core/html/HTMLFormElement.h b/Source/core/html/HTMLFormElement.h

index 7404e5a885191d20bf38a323627d2d288cd31fd0..44abdcc0237507b45076d57093b98e2586a2d73c 100644

--- a/Source/core/html/HTMLFormElement.h

+++ b/Source/core/html/HTMLFormElement.h

@@ -47,7 +47,7 @@ public:

virtual ~HTMLFormElement();

virtual void trace(Visitor*) override;

- void setNeedsValidityCheck();

+ void setNeedsValidityCheck(ValidityChangeAction, bool isValid);

PassRefPtrWillBeRawPtr<HTMLFormControlsCollection> elements();

void getNamedElements(const AtomicString&, WillBeHeapVector<RefPtrWillBeMember<Element> >&);

@@ -185,6 +185,8 @@ private:

bool m_wasDemoted : 1;

+ int m_invalidControlsCount;

OwnPtrWillBeMember<GenericEventQueue> m_pendingAutocompleteEventsQueue;

};

« Source/core/html/HTMLFormControlElement.cpp ('K') | « Source/core/html/HTMLFormControlElement.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »