Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: Source/core/html/HTMLFormElement.h

Issue 672163002: Fix bug where form/fieldset :valid/:invalid won't be recalculated upon control's willValidate change Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixes to the logic Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLFormControlElement.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFormElement.h
diff --git a/Source/core/html/HTMLFormElement.h b/Source/core/html/HTMLFormElement.h
index 7404e5a885191d20bf38a323627d2d288cd31fd0..e472fea50c44fea43b8f4988725fe7b428a1370a 100644
--- a/Source/core/html/HTMLFormElement.h
+++ b/Source/core/html/HTMLFormElement.h
@@ -47,7 +47,7 @@ public:
virtual ~HTMLFormElement();
virtual void trace(Visitor*) override;
- void setNeedsValidityCheck();
+ void setNeedsValidityCheck(ValidityRecalcReason, bool isValid);
PassRefPtrWillBeRawPtr<HTMLFormControlsCollection> elements();
void getNamedElements(const AtomicString&, WillBeHeapVector<RefPtrWillBeMember<Element> >&);
@@ -185,6 +185,10 @@ private:
bool m_wasDemoted : 1;
+ // Number of invalid elements associated to the form that are candidates
+ // for constraint validation (their willValidate state is true).
+ int m_invalidControlsCount;
+
OwnPtrWillBeMember<GenericEventQueue> m_pendingAutocompleteEventsQueue;
};
« no previous file with comments | « Source/core/html/HTMLFormControlElement.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698