Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 672163002: Fix bug where form/fieldset :valid/:invalid won't be recalculated upon control's willValidate change Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add layout tests to catch the problem Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 1428 matching lines...) Expand 10 before | Expand all | Expand 10 after
1439 { 1439 {
1440 m_inputTypeView->updateClearButtonVisibility(); 1440 m_inputTypeView->updateClearButtonVisibility();
1441 } 1441 }
1442 1442
1443 void HTMLInputElement::willChangeForm() 1443 void HTMLInputElement::willChangeForm()
1444 { 1444 {
1445 removeFromRadioButtonGroup(); 1445 removeFromRadioButtonGroup();
1446 HTMLTextFormControlElement::willChangeForm(); 1446 HTMLTextFormControlElement::willChangeForm();
1447 } 1447 }
1448 1448
1449 void HTMLInputElement::didChangeForm() 1449 void HTMLInputElement::didChangeForm(HTMLFormElement* oldForm)
1450 { 1450 {
1451 HTMLTextFormControlElement::didChangeForm(); 1451 HTMLTextFormControlElement::didChangeForm(oldForm);
1452 addToRadioButtonGroup(); 1452 addToRadioButtonGroup();
1453 } 1453 }
1454 1454
1455 Node::InsertionNotificationRequest HTMLInputElement::insertedInto(ContainerNode* insertionPoint) 1455 Node::InsertionNotificationRequest HTMLInputElement::insertedInto(ContainerNode* insertionPoint)
1456 { 1456 {
1457 if (insertionPoint->inDocument()) { 1457 if (insertionPoint->inDocument()) {
1458 V8DOMActivityLogger* activityLogger = V8DOMActivityLogger::currentActivi tyLoggerIfIsolatedWorld(); 1458 V8DOMActivityLogger* activityLogger = V8DOMActivityLogger::currentActivi tyLoggerIfIsolatedWorld();
1459 if (activityLogger) { 1459 if (activityLogger) {
1460 Vector<String> argv; 1460 Vector<String> argv;
1461 argv.append("input"); 1461 argv.append("input");
(...skipping 385 matching lines...) Expand 10 before | Expand all | Expand 10 after
1847 { 1847 {
1848 listAttributeTargetChanged(); 1848 listAttributeTargetChanged();
1849 } 1849 }
1850 1850
1851 AXObject* HTMLInputElement::popupRootAXObject() 1851 AXObject* HTMLInputElement::popupRootAXObject()
1852 { 1852 {
1853 return m_inputTypeView->popupRootAXObject(); 1853 return m_inputTypeView->popupRootAXObject();
1854 } 1854 }
1855 1855
1856 } // namespace 1856 } // namespace
OLDNEW
« Source/core/html/HTMLFormControlElement.cpp ('K') | « Source/core/html/HTMLInputElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698