Fix bug where form/fieldset :valid/:invalid won't be recalculated upon control's willValidate change

Source/core/html/HTMLFormControlElement.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 16 matching lines @@
 #include "core/html/FormAssociatedElement.h"
 #include "core/html/LabelableElement.h"
 
 namespace blink {
 
 class FormDataList;
 class HTMLFormElement;
 class ValidationMessageClient;
 
 enum CheckValidityEventBehavior { CheckValidityDispatchNoEvent, CheckValidityDispatchInvalidEvent };
+enum ValidityChangeAction { ElementAddition, ElementRemoval, ElementModification };

[keishi, 2014/10/24 10:25:49]

nit: It might be just me. The name * Action gives me the impression of a pending
task. I would prefer ValidityChangeReason or ValidityChangeType but I don't have
strong feelings.

[Bartek Nowierski, 2014/10/24 10:48:30]

Reason seems like a much better option. Done.

 
 // HTMLFormControlElement is the default implementation of FormAssociatedElement,
 // and form-associated element implementations should use HTMLFormControlElement
 // unless there is a special reason.
 class HTMLFormControlElement : public LabelableElement, public FormAssociatedElement {
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(HTMLFormControlElement);
 
 public:
     virtual ~HTMLFormControlElement();
     virtual void trace(Visitor*) override;
@@ skipping 73 matching lines @@
 
 protected:
     HTMLFormControlElement(const QualifiedName& tagName, Document&, HTMLFormElement*);
 
     virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;
     virtual void requiredAttributeChanged();
     virtual void disabledAttributeChanged();
     virtual void attach(const AttachContext& = AttachContext()) override;
     virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;
     virtual void removedFrom(ContainerNode*) override;
-    virtual void willChangeForm() override;
-    virtual void didChangeForm() override;
+    virtual void didChangeForm(HTMLFormElement* oldForm) override;
     virtual void didMoveToNewDocument(Document& oldDocument) override;
 
     virtual bool supportsFocus() const override;
     virtual bool isKeyboardFocusable() const override;
     virtual bool shouldShowFocusRingOnMouseFocus() const;
     virtual bool shouldHaveFocusAppearance() const override final;
     virtual void dispatchBlurEvent(Element* newFocusedElement) override;
     virtual void dispatchFocusEvent(Element* oldFocusedElement, FocusType) override;
     virtual void willCallDefaultEventHandler(const Event&) override final;
 
@@ skipping 13 matching lines @@
 #endif
 
     virtual bool isFormControlElement() const override final { return true; }
     virtual bool alwaysCreateUserAgentShadowRoot() const override { return true; }
 
     virtual short tabIndex() const override final;
 
     virtual bool isDefaultButtonForForm() const override final;
     virtual bool isValidElement() override;
     virtual bool matchesValidityPseudoClasses() const override;
+    // Refreshes willValidate cache. Returns true if anything changed.
+    bool refreshWillValidate();
     void updateAncestorDisabledState() const;
 
     bool isValidationMessageVisible() const;
     ValidationMessageClient* validationMessageClient() const;
 
     // Requests validity recalc for the form owner, if one exists.
-    void formOwnerSetNeedsValidityCheck();
+    void formOwnerSetNeedsValidityCheck(ValidityChangeAction, bool isValid);
     // Requests validity recalc for all ancestor fieldsets, if exist.
     void fieldSetAncestorsSetNeedsValidityCheck(Node*);
 
     bool m_disabled : 1;
     bool m_isAutofilled : 1;
     bool m_isReadOnly : 1;
     bool m_isRequired : 1;
     bool m_hasValidationMessage : 1;
 
     enum AncestorDisabledState { AncestorDisabledStateUnknown, AncestorDisabledStateEnabled, AncestorDisabledStateDisabled };
@@ skipping 19 matching lines @@
 {
     return element.isFormControlElement();
 }
 
 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFormControlElement);
 DEFINE_TYPE_CASTS(HTMLFormControlElement, FormAssociatedElement, control, control->isFormControlElement(), control.isFormControlElement());
 
 } // namespace
 
 #endif