Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 672143002: Remove valgrind suppression entry for WebBlobRegistry::addDataToStream() (Closed)

Created:
6 years, 2 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 1 month ago
Reviewers:
yhirano
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove valgrind suppression entry for WebBlobRegistry::addDataToStream() It looks fixed. The bot is no longer running the test, so ran valgrind locally. R=yhirano NOTRY=true BUG=417093 Committed: https://crrev.com/853e5a966996ede02afcd4c0f778c1e6eefb8c7a Cr-Commit-Position: refs/heads/master@{#301314}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
tyoshino (SeeGerritForStatus)
6 years, 2 months ago (2014-10-23 05:53:30 UTC) #2
yhirano
lgtm
6 years, 2 months ago (2014-10-23 09:06:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672143002/20001
6 years, 1 month ago (2014-10-27 04:18:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 04:18:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672143002/20001
6 years, 1 month ago (2014-10-27 04:18:54 UTC) #10
commit-bot: I haz the power
Failed to apply the patch.
6 years, 1 month ago (2014-10-27 04:19:14 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 04:19:31 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/853e5a966996ede02afcd4c0f778c1e6eefb8c7a
Cr-Commit-Position: refs/heads/master@{#301314}

Powered by Google App Engine
This is Rietveld 408576698