Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 67212: Fixes to make shared build work for app (chrome) target on linux. (Closed)

Created:
11 years, 8 months ago by Craig Schlenter
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai, sgk
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixes to make shared build work for app (chrome) target on linux. - remove unused ffmpeg files from link - remove unnecessary views files - resolve testing::internal::AssertHelper::AssertHelper - add IconRecord - add WebCore::Coordinates::toString() - add SkUnPreMultiply::gTable - remove Version.xcconfig from sources - use rpath so shared link chrome can run from build dir

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove Version.xcconfig mess from patch 1 #

Patch Set 3 : merge with HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M build/common.gypi View 1 2 1 chunk +8 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M media/media.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M net/net.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M skia/skia.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webkit/webkit.gyp View 1 2 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Craig Schlenter
I've only tested these changes on linux and they will only work for 'hammer app'. ...
11 years, 8 months ago (2009-04-16 17:13:53 UTC) #1
Mark Mentovai
Early comment. Not a complete review. BTW, use mark@chromium.org. I didn't see this review initially ...
11 years, 8 months ago (2009-04-17 16:28:15 UTC) #2
Craig Schlenter
On 2009/04/17 16:28:15, Mark Mentovai wrote: > Early comment. Not a complete review. > > ...
11 years, 8 months ago (2009-04-17 17:29:18 UTC) #3
Craig Schlenter
11 years, 8 months ago (2009-04-21 05:15:26 UTC) #4
Updated patch to sync with changes in HEAD for $_LIBDIRFLAGS in common.gypi.
Updated description to remove comment about dependency on
http://codereview.chromium.org/67207 and updated description of Version.xcconfig
change.

Powered by Google App Engine
This is Rietveld 408576698